Release Workflow Improvements

Vinyzu · Vinyzu · commit 3ff822977e77 · 2026-06-02T18:05:23.000+02:00
diff --git a/.github/workflows/patchright_release.yml b/.github/workflows/patchright_release.yml
@@ -5,45 +5,48 @@ on:
   workflow_dispatch:
     inputs:
       version:
-        description: 'Playwright Version (Base)'
+        description: 'Playwright Version (e.g. v1.58.0 or 1.58.0)'
         default: ''
       patchright_release:
-        description: 'Patchright Release Version (e.g. `1.55.2`)'
+        description: 'Patchright Release Version (e.g. v1.58.0 or 1.58.0) on pypi'
         default: ''
   # running every hour
   schedule:
     - cron: '0 * * * *'
 
 env:
   REPO: ${{ github.repository }}
+  patchright_release: ${{ github.event.inputs.patchright_release || '' }}
 
 jobs:
-  patchright-release-workflow:
-    name: "Patchright-Python Workflow: Install, Patch, Build and Publish Patchright Python Package"
+  check-release-version:
+    name: Check Release Version
     runs-on: ubuntu-latest
-    environment:
-      name: pypi
-      url: https://pypi.org/p/patchright
-    permissions:
-      contents: write
-      id-token: write # For trusted Publishing
+    outputs:
+      proceed: ${{ steps.version_check.outputs.proceed }}
+      playwright_version: ${{ steps.version_check.outputs.playwright_version }}
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v6
 
-      - name: Install uv
-        uses: astral-sh/setup-uv@v7
-
-      - name: Set up Python
-        run: uv python install
-
       - name: Check Release Version
         id: version_check
         run: |
-          echo "patchright_release=${{ github.event.inputs.patchright_release }}" >> $GITHUB_ENV
           PLAYWRIGHT_VERSION=""
           if [ -n "${{ github.event.inputs.version }}" ]; then
-            PLAYWRIGHT_VERSION="${{ github.event.inputs.version }}"
+            raw_version="${{ github.event.inputs.version }}"
+            PLAYWRIGHT_VERSION="v${raw_version#v}"
+            echo "proceed=true" >>$GITHUB_OUTPUT
+            echo "playwright_version=$PLAYWRIGHT_VERSION" >> $GITHUB_ENV
+            if [ -n "${{ github.event.inputs.patchright_release }}" ]; then
+              raw_patchright_release="${{ github.event.inputs.patchright_release }}"
+              echo "patchright_release=${raw_patchright_release#v}" >> $GITHUB_ENV
+            fi
+          elif [ -n "${{ github.event.inputs.patchright_release }}" ]; then
+            raw_patchright_release="${{ github.event.inputs.patchright_release }}"
+            echo "patchright_release=${raw_patchright_release#v}" >> $GITHUB_ENV
+            response=$(curl --silent "https://api.github.com/repos/microsoft/playwright-python/releases/latest")
+            PLAYWRIGHT_VERSION=$(echo "$response" | grep '"tag_name"' | sed -E 's/.*"([^"]+)".*/\1/')
             echo "proceed=true" >>$GITHUB_OUTPUT
             echo "playwright_version=$PLAYWRIGHT_VERSION" >> $GITHUB_ENV
           else
@@ -55,12 +58,41 @@ jobs:
             echo "playwright_version=$PLAYWRIGHT_VERSION" >> $GITHUB_OUTPUT
           fi
 
+  run-patchright-tests:
+    name: Run Patchright Tests
+    needs: check-release-version
+    if: needs.check-release-version.outputs.proceed == 'true'
+    uses: ./.github/workflows/patchright_tests.yml
+    with:
+      playwright_version: ${{ needs.check-release-version.outputs.playwright_version }}
+
+  patchright-release-workflow:
+    name: "Patchright-Python Workflow: Install, Patch, Build and Publish Patchright Python Package"
+    needs: [check-release-version, run-patchright-tests]
+    runs-on: ubuntu-latest
+    environment:
+      name: pypi
+      url: https://pypi.org/p/patchright
+    permissions:
+      contents: write
+      id-token: write # For trusted Publishing
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v6
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v7
+
+      - name: Set up Python
+        run: uv python install
+
       - name: Install Playwright-Python Package
-        if: steps.version_check.outputs.proceed == 'true'
+        env:
+          playwright_version: ${{ needs.check-release-version.outputs.playwright_version }}
         run: |
           uv sync --all-groups
           if [ -n "$patchright_release" ]; then
-            PATCHRIGHT_RELEASE="$patchright_release"
+            PATCHRIGHT_RELEASE="${patchright_release#v}"
           else
             PLAYWRIGHT_MINOR=${playwright_version#v}
             PLAYWRIGHT_MINOR=${PLAYWRIGHT_MINOR%.*}
@@ -72,13 +104,11 @@ jobs:
           uv add -r playwright-python/local-requirements.txt --dev
 
       - name: Patch Playwright-Python Package
-        if: steps.version_check.outputs.proceed == 'true'
         run: |
           uv run patch_python_package.py
           uvx ruff format playwright-python
 
       - name: Build Patchright-Python Package
-        if: steps.version_check.outputs.proceed == 'true'
         run: |
           cd playwright-python
           uv pip install -e .
@@ -87,21 +117,19 @@ jobs:
           done
 
       - name: Create Empty Versioning Release
-        if: steps.version_check.outputs.proceed == 'true'
         uses: actions/create-release@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          tag_name: ${{ steps.version_check.outputs.playwright_version }}
-          release_name: ${{ steps.version_check.outputs.playwright_version }}
+          tag_name: ${{ needs.check-release-version.outputs.playwright_version }}
+          release_name: ${{ needs.check-release-version.outputs.playwright_version }}
           body: |
             This is an automatic deployment in response to a new release of [microsoft/playwright-python](https://github.com/microsoft/playwright-python).
             This Release is only used for Versioning.
           draft: false
           prerelease: false
 
       - name: Publish Patchright-Python Package
-        if: steps.version_check.outputs.proceed == 'true'
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           packages-dir: playwright-python/dist/
diff --git a/.github/workflows/patchright_tests.yml b/.github/workflows/patchright_tests.yml
@@ -1,7 +1,18 @@
 name: Patchright Chromium Tests
 
 on:
+  workflow_call:
+    inputs:
+      playwright_version:
+        description: 'Playwright Version to test against, e.g. v1.58.0 or 1.58.0. If empty, latest release is used.'
+        required: false
+        type: string
   workflow_dispatch:
+    inputs:
+      playwright_version:
+        description: 'Playwright Version to test against, e.g. v1.58.0 or 1.58.0. If empty, latest release is used.'
+        required: false
+        type: string
   push:
     branches: [main]
   pull_request:
@@ -25,7 +36,12 @@ jobs:
       - name: Install Playwright-Python Package
         run: |
           uv sync --all-groups
-          PLAYWRIGHT_TAG=$(curl -fsSL "https://api.github.com/repos/microsoft/playwright-python/releases/latest" | jq -r '.tag_name')
+          PLAYWRIGHT_TAG="${{ inputs.playwright_version || github.event.inputs.playwright_version }}"
+          if [ -z "$PLAYWRIGHT_TAG" ]; then
+            PLAYWRIGHT_TAG=$(curl -fsSL "https://api.github.com/repos/microsoft/playwright-python/releases/latest" | jq -r '.tag_name')
+          else
+            PLAYWRIGHT_TAG="v${PLAYWRIGHT_TAG#v}"
+          fi
           PLAYWRIGHT_MINOR=${PLAYWRIGHT_TAG#v}
           PLAYWRIGHT_MINOR=${PLAYWRIGHT_MINOR%.*}
           PATCHRIGHT_RELEASE=$(curl -fsSL "https://api.github.com/repos/Kaliiiiiiiiii-Vinyzu/patchright/releases?per_page=100" | jq -r --arg minor "$PLAYWRIGHT_MINOR" '[.[].tag_name | ltrimstr("v") | select(startswith($minor + ".")) | select((try (split(".") | map(tonumber) | length) catch 0) == 3)] | sort_by(split(".") | map(tonumber)) | last')
