Skip to content

feat: Filtering duplicates in home/recent #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richard-hajek wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat: Filtering duplicates in home/recent #2259

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e287ab
Merge pull request #1981 from KRTirtho/dev
KRTirtho Oct 9, 2024
94e7040
Merge branch 'dev'
KRTirtho Oct 9, 2024
8c1337d
Merge pull request #2118 from KRTirtho/dev
KRTirtho Dec 8, 2024
42e9544
feat: added filtering duplicates in recent
richard-hajek Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions lib/modules/home/sections/recent.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import 'package:spotube/provider/history/recent.dart';

class HomeRecentlyPlayedSection extends HookConsumerWidget {
const HomeRecentlyPlayedSection({super.key});

@override
Widget build(BuildContext context, ref) {
final history = ref.watch(recentlyPlayedItems);
Expand All @@ -20,17 +20,20 @@ class HomeRecentlyPlayedSection extends HookConsumerWidget {
return const SizedBox();
}

final uniqueItems = <dynamic>{};
final filteredItems = [
for (final item in historyData)
if (item.playlist != null && item.playlist?.id != null && uniqueItems.add(item.playlist!.id!))
item.playlist
else if (item.album != null && item.album?.id != null && uniqueItems.add(item.album?.id))
item.album
];

return Skeletonizer(
enabled: history.isLoading,
child: HorizontalPlaybuttonCardView(
title: Text(context.l10n.recently_played),
items: [
for (final item in historyData)
if (item.playlist != null)
item.playlist
else if (item.album != null)
item.album
],
items: filteredItems,
hasNextPage: false,
isLoadingNextPage: false,
onFetchMore: () {},
Expand Down