feat: support non-standard retry-after header formats #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for non-standard retry-after header formats used by CivicPlus and other services that use "30s" or "1m30s" notation instead of the standard seconds or HTTP date format. Changes: - Extract retry-after parsing logic into parseRetryAfter() method - Add regex support for "Xs" and "XmYs" time formats - Add tests for non-standard formats (3s, 1m1s) - Fix missing redirect parameter in 405 and fallback GET requests Closes #556 Co-authored-by: Michael Rienstra <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for non-standard retry-after header formats used by CivicPlus and other services that use "30s" or "1m30s" notation instead of the standard seconds or HTTP date format.
This addresses the issue raised in #556 where services like CivicPlus return retry-after headers in formats like:
3s(3 seconds)1m30s(1 minute 30 seconds)Changes
parseRetryAfter()method/^(?:(\d+)m)?(\d+)s$/Test Results
All 135 tests pass, including 2 new tests for non-standard retry-after formats:
should retry 429s with non-standard seconds format (3s)should retry 429s with non-standard minutes and seconds format (1m1s)Backward Compatibility
This change maintains full backward compatibility with existing retry-after header formats:
30Wed, 21 Oct 2015 07:28:00 GMTCredits
Based on the original implementation proposed by @mrienstra in #556. Updated to work with the current codebase (native fetch, redirect handling, etc).
Closes #556
🤖 Generated with Claude Code