Skip to content

Conversation

@musm
Copy link
Contributor

@musm musm commented Apr 29, 2017

No description provided.

@musm
Copy link
Contributor Author

musm commented Apr 29, 2017

JuliaLang/julia#21540

@codecov-io
Copy link

codecov-io commented Apr 29, 2017

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files          25       25           
  Lines         943      943           
=======================================
  Hits          885      885           
  Misses         58       58
Impacted Files Coverage Δ
src/tzdata/archive.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc051e...0d140e0. Read the comment docs.

Copy link
Member

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

import Compat: @static, is_windows

if is_windows()
const exe7z = joinpath(JULIA_HOME, "7z.exe")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this to 7Z?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately not, can't start with a number 7Z = 7*Z

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that slipped my mind.

@omus omus merged commit 87155d0 into JuliaTime:master Apr 29, 2017
@musm musm deleted the patch-1 branch April 29, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants