optimize hals update to matrix multiplication #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
reviewed
Feb 10, 2025
Collaborator
timholy
left a comment
timholy
left a comment
There was a problem hiding this comment.
I don't have any objections to this change.
| function CoordinateDescentState{T}(X, W, H, violation, violation_init) where T | ||
| p, n, k = nmf_checksize(X, W, H) | ||
| new{T}(W * H, | ||
| new{T}(W * H, |
Collaborator
There was a problem hiding this comment.
This line has trailing whitespace that would ideally be deleted. See https://bobbyhadz.com/blog/remove-trailing-whitespace-vscode for instructions about doing this automatically in vscode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the update rule of HALS to matrix multiplication. It is the same equation as the old version but the old one update W and H element by element