Merge pull request #70 from SimonDanisch/master

fix calls to constructor

Author: andreasnoack

src/Loess.jl

@@ -136,7 +136,7 @@ function loess(
         ]
     end
 
-    LoessModel(xs, ys, predictions_and_gradients, kdtree)
+    LoessModel(convert(Matrix{T}, xs), convert(Vector{T}, ys), predictions_and_gradients, kdtree)
 end
 
 loess(xs::AbstractVector{T}, ys::AbstractVector{T}; kwargs...) where {T<:AbstractFloat} =

src/kd.jl

@@ -65,7 +65,7 @@ function KDTree(
 
     root = build_kdtree(xs, perm, bounds, leaf_size_cutoff, leaf_diameter_cutoff, verts)
 
-    KDTree(xs, collect(1:n), root, verts, bounds)
+    KDTree(convert(Matrix{T}, xs), collect(1:n), root, verts, bounds)
 end
 
 
@@ -276,4 +276,3 @@ function _traverse!(bounds, node::KDNode, x)
         return _traverse!(bounds, node.rightnode, x)
     end
 end
-

test/runtests.jl

@@ -25,6 +25,12 @@ using RDatasets
     @test Loess.predict(model,x) ≈ y
 end
 
+@testset "reshaped views" begin
+    # See: https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/462
+    # and: https://github.com/JuliaStats/Loess.jl/pull/70
+    @test Loess.loess(reshape(view(rand(4), 1:4), (4, 1)), rand(4)) isa Loess.LoessModel
+end
+
 @testset "sine" begin
     x = 1:10
     y = sin.(1:10)