-
Notifications
You must be signed in to change notification settings - Fork 18
Fast threaded matmul #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests pass locally (with ThreadingUtilities.jl installed). |
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
============================================
- Coverage 100.00% 12.23% -87.77%
============================================
Files 9 12 +3
Lines 121 719 +598
============================================
- Hits 121 88 -33
- Misses 0 631 +631
Continue to review full report at Codecov.
|
|
@chriselrod Any idea what's causing these test failures? |
93b42b5 to
7458b38
Compare
|
Let's mark the CodeCov checks as not required for now. We can increase the code coverage in future PRs. LGTM to merge once CI is green. It's just the x86 that's left to fix now? |
|
I unmarked the codecov statuses as required. BTW you have the access to change those settings if you want. You should see it under settings, branches, branch protection settings. |
|
Good to merge? |
|
It'd be nice if we could query some information about how big the stack is. 64-bit is stack allocating Fortran and LLVM both let you stack allocate dynamically sized arrays, but Julia does not, meaning I need to pick some fixed upper bound. So for the time being, it just allocates |
Depends on ThreadingUtilities.jl, which will be registered in a few days.