-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Try to fix fma on windows
#43530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix fma on windows
#43530
Conversation
|
having written the Julia version of this, congrats on having the fortitude it takes to rewrite this! This looks like the best solution to windows being bad for now. |
|
@oscardssmith Linux32's runtime |
|
32 bit linux is passing those tests on master, so they should continue to be tested and pass. |
|
|
|
that should be OK. |
c74e4a2 to
063b89c
Compare
vtjnash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. What is wrong with linux32?
|
I'm not sure, runtime |
1. add `volatile` to fix Win32 2. fix `issubnormal` on Win32
Update math.jl
|
All test passed after rebasing @vtjnash |
* enable fma on Windows
* enable fma on Windows
* enable fma on Windows
This PR aims to fix runtime
fmaon windows by addingjulia_fma(f)usingBase.fma_emulatedas the reference.On other systems,
usejulia_fma(f)callfma(f)directly.I use
Base.fma_floatto testjulia_fma(f)'s precison. And it passed locally.Since it only affects const propagation, I believe perfomance is not important.
We can remove this code if
fmaon windows get fixed in the future.Close #43386.