fix some convert methods that depwarned #23494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
added
bugfix
Sacha0
reviewed
Aug 29, 2017
base/linalg/special.jl
Outdated
| # Methods operating on different special matrix types | ||
|
|
||
| # Interconversion between special matrix types | ||
| convert(::Type{Bidiagonal}, A::Diagonal{T}) where {T} = |
Member
There was a problem hiding this comment.
Is the where {T} now superfluous? And likewise below?
Sacha0
reviewed
Aug 29, 2017
base/linalg/special.jl
Outdated
| Tridiagonal(A.uplo == 'U' ? zeros(T, size(A.dv,1)-1) : A.ev, A.dv, | ||
| A.uplo == 'U' ? A.ev : zeros(T, size(A.dv,1)-1)) | ||
| Tridiagonal(A.uplo == 'U' ? fill!(similar(A.diag, length(A.diag)-1), 0) : A.ev, A.dv, | ||
| A.uplo == 'U' ? A.ev : fill!(similar(A.diag, length(A.diag)-1), 0)) |
Member
There was a problem hiding this comment.
Did you intend to map .dv to .diag?
Member
Author
There was a problem hiding this comment.
Nope, hence the testfailures.
fredrikekre
force-pushed
the
fe/convert-diag
branch
from
9d035c1 to
bea9180
Compare
Member
Author
|
#23371 on BSD, download failure on one of AV. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up from #22718, #22925, #23035 and #23154. These methods previously depwarned when called with a
Diagonalwrapping other types of vectors.