Skip to content

rename AbstractIOBuffer => GenericIOBuffer (close #17360)#22796

Merged
JeffBezanson merged 2 commits into
masterfrom
sk/GenericIOBuffer
Jul 14, 2017
Merged

rename AbstractIOBuffer => GenericIOBuffer (close #17360)#22796
JeffBezanson merged 2 commits into
masterfrom
sk/GenericIOBuffer

Conversation

@StefanKarpinski

Copy link
Copy Markdown
Member

Replaces #17360.

@tkelman

tkelman commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

this should @deprecate_binding AbstractIOBuffer GenericIOBuffer false and be added to NEWS

@tkelman tkelman added deprecation This change introduces or involves a deprecation needs news A NEWS entry is required for this change labels Jul 13, 2017

@Sacha0 Sacha0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

@JeffBezanson JeffBezanson removed the needs news A NEWS entry is required for this change label Jul 14, 2017
@JeffBezanson
JeffBezanson merged commit 9ea80a4 into master Jul 14, 2017
@tkelman
tkelman deleted the sk/GenericIOBuffer branch July 14, 2017 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation This change introduces or involves a deprecation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants