[1.0-dev] Store indices in CartesianRange#20974
Conversation
|
Not having understood all the ends this change seeps into yet, one question: |
|
Because the indices in |
|
And also changing |
|
@timholy |
5cad699 to
534ff9e
Compare
|
That's not defined currently, but heck yeah, that's a better way to "spell" that conversion. Updated. |
|
bump, revisit? |
|
Yup, on my agenda. I'm a bit focused on finishing #22210 now, but once the dust settles there I'll rebase this. |
140dc81 to
71f7049
Compare
| # END 0.7 deprecations | ||
|
|
||
| # BEGIN 1.0 deprecations | ||
| function CartesianRange{N}(start::CartesianIndex{N}, stop::CartesianIndex{N}) |
71f7049 to
0a03942
Compare
The main advantage of this change is that you no longer lose type information from `CartesianRange(indices(A))`. The types of the specific AbstractUnitRanges are important for `similar`, etc.
0a03942 to
2e0601e
Compare
The main advantage of this change is that you no longer lose type information from
CartesianRange(indices(A)). The types of the specific AbstractUnitRanges are important forsimilar, if you're using non-1 indices. It's also kind of nice to be able to writeCartesianRange{3}rather thanCartesianRange{CartesianIndex{3}}.Because this changes the parametrization of an exported type, and also introduces a new depwarn, this is queued for after 0.6.
CC @JKrehl.