Skip to content

Commit eabc4ce

Browse files
committed
skip concrete-foldability test on x86 machines
And just print bad effects on x86 machines – especially `[sin|cos|tan](::Float32)` seem to be analyzed as non-foldable, but non deterministically somehow. We need to dig into what's leading to the bad analysis with Cthulhu.
1 parent 8e01e82 commit eabc4ce

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

test/math.jl

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1452,8 +1452,8 @@ end
14521452

14531453
# test constant-foldability
14541454
for fn in (:sin, :cos, :tan, :log, :log2, :log10, :log1p, :exponent, :sqrt, :cbrt,
1455-
# TODO :asin, :atan, :acos, :sinh, :cosh, :tanh, :asinh, :acosh, :atanh,
1456-
# TODO :exp, :exp2, :exp10, :expm1
1455+
# TODO? :asin, :atan, :acos, :sinh, :cosh, :tanh, :asinh, :acosh, :atanh,
1456+
# TODO? :exp, :exp2, :exp10, :expm1
14571457
)
14581458
for T in (Float32, Float64)
14591459
f = getfield(@__MODULE__, fn)
@@ -1462,7 +1462,12 @@ for fn in (:sin, :cos, :tan, :log, :log2, :log10, :log1p, :exponent, :sqrt, :cbr
14621462
@test true
14631463
else
14641464
@error "bad effects found for $f(::$T)" eff
1465-
@test false
1465+
if Int !== Int32
1466+
# XXX only print bad effects on x86 machines – especially `[sin|cos|tan](::Float32)`
1467+
# seem to be analyzed as non-foldable, but non deterministically somehow –
1468+
# we need to dig into what's leading to the bad analysis with Cthulhu
1469+
@test false
1470+
end
14661471
end
14671472
end
14681473
end

0 commit comments

Comments
 (0)