Skip to content

Commit ceaeb7b

Browse files
committed
Fix installing lld when using USE_BINARYBUILDER_LLVM=0
1 parent 56451d8 commit ceaeb7b

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

deps/llvm.mk

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,23 @@ include $(SRCDIR)/llvm.version
33
include $(SRCDIR)/llvm-ver.make
44
include $(SRCDIR)/llvm-options.mk
55

6+
# We provide a way to subversively swap out which LLVM JLL we pull artifacts from
7+
ifeq ($(LLVM_ASSERTIONS), 1)
8+
# LLVM_JLL_DOWNLOAD_NAME := libLLVM_assert
9+
# LLVM_JLL_VER := $(LLVM_ASSERT_JLL_VER)
10+
# LLVM_TOOLS_JLL_DOWNLOAD_NAME := LLVM_assert
11+
# LLVM_TOOLS_JLL_VER := $(LLVM_TOOLS_ASSERT_JLL_VER)
12+
LLVM_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ).asserts
13+
CLANG_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ).asserts
14+
LLD_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ).asserts
15+
LLVM_TOOLS_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ).asserts
16+
else
17+
LLVM_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ)
18+
CLANG_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ)
19+
LLD_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ)
20+
LLVM_TOOLS_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ)
21+
endif
22+
623
ifneq ($(USE_BINARYBUILDER_LLVM), 1)
724
LLVM_GIT_URL:=https://github.com/JuliaLang/llvm-project.git
825
LLVM_TAR_URL=https://api.github.com/repos/JuliaLang/llvm-project/tarball/$1
@@ -40,6 +57,8 @@ LLVM_ENABLE_RUNTIMES :=
4057
ifeq ($(BUILD_LLVM_CLANG), 1)
4158
LLVM_ENABLE_PROJECTS := $(LLVM_ENABLE_PROJECTS);clang
4259
LLVM_ENABLE_RUNTIMES := $(LLVM_ENABLE_RUNTIMES);compiler-rt
60+
else
61+
$(eval $(call bb-install,clang,CLANG,false,true))
4362
endif
4463
ifeq ($(USE_POLLY), 1)
4564
LLVM_ENABLE_PROJECTS := $(LLVM_ENABLE_PROJECTS);polly
@@ -58,6 +77,8 @@ LLVM_ENABLE_RUNTIMES := $(LLVM_ENABLE_RUNTIMES);libcxx;libcxxabi
5877
endif
5978
ifeq ($(BUILD_LLD), 1)
6079
LLVM_ENABLE_PROJECTS := $(LLVM_ENABLE_PROJECTS);lld
80+
else
81+
$(eval $(call bb-install,lld,LLD,false,true))
6182
endif
6283

6384

@@ -316,23 +337,6 @@ endif
316337

317338
else # USE_BINARYBUILDER_LLVM
318339

319-
# We provide a way to subversively swap out which LLVM JLL we pull artifacts from
320-
ifeq ($(LLVM_ASSERTIONS), 1)
321-
# LLVM_JLL_DOWNLOAD_NAME := libLLVM_assert
322-
# LLVM_JLL_VER := $(LLVM_ASSERT_JLL_VER)
323-
# LLVM_TOOLS_JLL_DOWNLOAD_NAME := LLVM_assert
324-
# LLVM_TOOLS_JLL_VER := $(LLVM_TOOLS_ASSERT_JLL_VER)
325-
LLVM_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ).asserts
326-
CLANG_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ).asserts
327-
LLD_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ).asserts
328-
LLVM_TOOLS_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ).asserts
329-
else
330-
LLVM_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ)
331-
CLANG_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ)
332-
LLD_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ)
333-
LLVM_TOOLS_JLL_TAGS := -llvm_version+$(LLVM_VER_MAJ)
334-
endif
335-
336340
$(eval $(call bb-install,llvm,LLVM,false,true))
337341
$(eval $(call bb-install,lld,LLD,false,true))
338342
$(eval $(call bb-install,clang,CLANG,false,true))

0 commit comments

Comments
 (0)