Commit c0c7415
committed
Miscellaneous
I'm not a big fan of this pass, or the way it's written. At a minimum, I'd expect
both better test coverage (when we write similar passes for the core Compiler, we
get away with weak test coverage by relying on user code) and a re-factor to make
this switch exhaustive (it should error if unexpected IR elements are encountered,
instead of just performing an incorrect transformation)
This doesn't make progress on those issues for now, but it at least fixes up a
couple of conspicuous problems I noticed when reviewing #56787Meta.partially_inline! fixes1 parent 9acf112 commit c0c7415
1 file changed
+16
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
362 | 362 | | |
363 | 363 | | |
364 | 364 | | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
365 | 378 | | |
366 | 379 | | |
367 | 380 | | |
| |||
376 | 389 | | |
377 | 390 | | |
378 | 391 | | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
379 | 395 | | |
380 | 396 | | |
381 | 397 | | |
| |||
0 commit comments