Deprecate Base.datatype_name to a name method

Author: ararslan

base/reflection.jl

@@ -143,9 +143,10 @@ fieldnames(t::UnionAll) = fieldnames(unwrap_unionall(t))
 fieldnames(t::Type{<:Tuple}) = Int[n for n in 1:fieldcount(t)]
 
 """
-    Base.datatype_name(t) -> Symbol
+    name(t::Type) -> Symbol
 
-Get the name of a (potentially UnionAll-wrapped) `DataType` (without its parent module) as a symbol.
+Get the name of a (potentially `UnionAll`-wrapped) `DataType` (without its parent module)
+as a symbol.
 
 # Examples
 ```jldoctest
@@ -155,12 +156,12 @@ julia> module Foo
        end
 Foo
 
-julia> Base.datatype_name(Foo.S{T} where T)
+julia> name(Foo.S{T} where T)
 :S
 ```
 """
-datatype_name(t::DataType) = t.name.name
-datatype_name(t::UnionAll) = datatype_name(unwrap_unionall(t))
+name(t::DataType) = t.name.name
+name(t::UnionAll) = name(unwrap_unionall(t))
 
 """
     Base.datatype_module(t::DataType) -> Module

doc/src/base/base.md

@@ -319,7 +319,6 @@ Base.fieldname
 Base.fieldcount
 Base.propertynames
 Base.datatype_module
-Base.datatype_name
 Base.isconst
 Base.function_module(::Function)
 Base.function_module(::Any, ::Any)

stdlib/Dates/src/parse.jl

@@ -16,7 +16,7 @@ function character_codes(directives::SimpleVector)
     return letters
 end
 
-genvar(t::DataType) = Symbol(lowercase(string(Base.datatype_name(t))))
+genvar(t::DataType) = Symbol(lowercase(string(name(t))))
 
 """
     tryparsenext_core(str::AbstractString, pos::Int, len::Int, df::DateFormat, raise=false)

test/reflection.jl

@@ -278,7 +278,7 @@ let
     @test Base.function_module(foo9475, (Any,)) == TestMod7648.TestModSub9475
     @test Base.function_module(foo9475) == TestMod7648.TestModSub9475
     @test Base.datatype_module(Foo7648) == TestMod7648
-    @test Base.datatype_name(Foo7648) == :Foo7648
+    @test name(Foo7648) == :Foo7648
     @test basename(functionloc(foo7648, (Any,))[1]) == "reflection.jl"
     @test first(methods(TestMod7648.TestModSub9475.foo7648)) == @which foo7648(5)
     @test TestMod7648 == @which foo7648