Replace 0 and 1 with zero(T) and oneunit(T) following PR 24656.

Author: ajkeller34

NEWS.md

@@ -520,11 +520,12 @@ Deprecated or removed
     `Meta.lower(module, ex)` ([#22064, #24278]).
 
   * `ones(A::AbstractArray[, opts...])` and `zeros(A::AbstractArray[, opts...])` methods
-    have been deprecated. The general replacement is `fill!(similar(A[, opts...]), {1|0})`,
+    have been deprecated. The general replacement is
+    `fill!(similar(A[, opts...]), {oneunit(eltype(A)) | zero(eltype(A))})`,
     though in most use cases simpler alternatives are better: For `zeros(A)`, consider
     `zero(A)`. For `ones(A)` or `zeros(A)`, consider `fill(v, size(A))` for `v` an
-    appropriate one or zero, `fill!(copy(A), {1|0})`, `ones(size(A))` or
-    `zeros(size(A))`, or any of the preceding with different element type
+    appropriate one or zero, `fill!(copy(A), {oneunit(eltype(A)) | zero(eltype(A))})`,
+    `ones(size(A))` or `zeros(size(A))`, or any of the preceding with different element type
     and/or shape depending on `opts...`. For an algebraic multiplicative identity,
     consider `one(A)` ([#24656]).
 

base/deprecated.jl

@@ -1689,14 +1689,14 @@ end
 # are deprecated in base/libgit2/types.jl.
 
 # deprecate ones/zeros methods accepting an array as first argument
-@deprecate ones(a::AbstractArray, ::Type{T}, dims::Tuple) where {T} fill!(similar(a, T, dims), 1)
-@deprecate ones(a::AbstractArray, ::Type{T}, dims...) where {T}     fill!(similar(a, T, dims...), 1)
-@deprecate ones(a::AbstractArray, ::Type{T}) where {T}              fill!(similar(a, T), 1)
-@deprecate ones(a::AbstractArray)                                   fill!(similar(a), 1)
-@deprecate zeros(a::AbstractArray, ::Type{T}, dims::Tuple) where {T}  fill!(similar(a, T, dims), 0)
-@deprecate zeros(a::AbstractArray, ::Type{T}, dims...) where {T}      fill!(similar(a, T, dims...), 0)
-@deprecate zeros(a::AbstractArray, ::Type{T}) where {T}               fill!(similar(a, T), 0)
-@deprecate zeros(a::AbstractArray)                                    fill!(similar(a), 0)
+@deprecate ones(a::AbstractArray, ::Type{T}, dims::Tuple) where {T} fill!(similar(a, T, dims), oneunit(T))
+@deprecate ones(a::AbstractArray, ::Type{T}, dims...) where {T}     fill!(similar(a, T, dims...), oneunit(T))
+@deprecate ones(a::AbstractArray, ::Type{T}) where {T}              fill!(similar(a, T), oneunit(T))
+@deprecate ones(a::AbstractArray)                                   fill!(similar(a), oneunit(eltype(a)))
+@deprecate zeros(a::AbstractArray, ::Type{T}, dims::Tuple) where {T}  fill!(similar(a, T, dims), zero(T))
+@deprecate zeros(a::AbstractArray, ::Type{T}, dims...) where {T}      fill!(similar(a, T, dims...), zero(T))
+@deprecate zeros(a::AbstractArray, ::Type{T}) where {T}               fill!(similar(a, T), zero(T))
+@deprecate zeros(a::AbstractArray)                                    fill!(similar(a), zero(eltype(a)))
 
 # PR #23711
 @eval LibGit2 begin

base/linalg/diagonal.jl

@@ -423,7 +423,7 @@ function svd(D::Diagonal{<:Number})
     piv = sortperm(S, rev = true)
     U   = Diagonal(D.diag ./ S)
     Up  = hcat([U[:,i] for i = 1:length(D.diag)][piv]...)
-    V   = Diagonal(fill!(similar(D.diag), 1))
+    V   = Diagonal(fill!(similar(D.diag), oneunit(eltype(D.diag))))
     Vp  = hcat([V[:,i] for i = 1:length(D.diag)][piv]...)
     return (Up, S[piv], Vp)
 end

base/linalg/tridiag.jl

@@ -270,9 +270,9 @@ function tril!(M::SymTridiagonal, k::Integer=0)
         return Tridiagonal(M.ev,M.dv,copy(M.ev))
     elseif k == -1
         fill!(M.dv,0)
-        return Tridiagonal(M.ev,M.dv,fill!(similar(M.ev), 0))
+        return Tridiagonal(M.ev,M.dv,zero(M.ev))
     elseif k == 0
-        return Tridiagonal(M.ev,M.dv,fill!(similar(M.ev), 0))
+        return Tridiagonal(M.ev,M.dv,zero(M.ev))
     elseif k >= 1
         return Tridiagonal(M.ev,M.dv,copy(M.ev))
     end
@@ -289,9 +289,9 @@ function triu!(M::SymTridiagonal, k::Integer=0)
         return Tridiagonal(M.ev,M.dv,copy(M.ev))
     elseif k == 1
         fill!(M.dv,0)
-        return Tridiagonal(fill!(similar(M.ev), 0),M.dv,M.ev)
+        return Tridiagonal(zero(M.ev),M.dv,M.ev)
     elseif k == 0
-        return Tridiagonal(fill!(similar(M.ev), 0),M.dv,M.ev)
+        return Tridiagonal(zero(M.ev),M.dv,M.ev)
     elseif k <= -1
         return Tridiagonal(M.ev,M.dv,copy(M.ev))
     end