Skip to content

Commit 8a776bd

Browse files
authored
Don't inadvertently export factorization internals via at-deprecate (#45935)
Accidentally introduced by #42594.
1 parent c31be80 commit 8a776bd

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

stdlib/LinearAlgebra/src/bunchkaufman.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ BunchKaufman(A::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer}, uplo::Abstra
8181
BunchKaufman{T,typeof(A),typeof(ipiv)}(A, ipiv, uplo, symmetric, rook, info)
8282
# backwards-compatible constructors (remove with Julia 2.0)
8383
@deprecate(BunchKaufman(LD, ipiv, uplo, symmetric, rook, info) where {T,S},
84-
BunchKaufman{T,S,typeof(ipiv)}(LD, ipiv, uplo, symmetric, rook, info))
84+
BunchKaufman{T,S,typeof(ipiv)}(LD, ipiv, uplo, symmetric, rook, info), false)
8585

8686
# iteration for destructuring into components
8787
Base.iterate(S::BunchKaufman) = (S.D, Val(:UL))

stdlib/LinearAlgebra/src/cholesky.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ CholeskyPivoted(A::AbstractMatrix{T}, uplo::AbstractChar, piv::AbstractVector{<:
168168
CholeskyPivoted{T,typeof(A),typeof(piv)}(A, uplo, piv, rank, tol, info)
169169
# backwards-compatible constructors (remove with Julia 2.0)
170170
@deprecate(CholeskyPivoted{T,S}(factors, uplo, piv, rank, tol, info) where {T,S<:AbstractMatrix},
171-
CholeskyPivoted{T,S,typeof(piv)}(factors, uplo, piv, rank, tol, info))
171+
CholeskyPivoted{T,S,typeof(piv)}(factors, uplo, piv, rank, tol, info), false)
172172

173173

174174
# iteration for destructuring into components

stdlib/LinearAlgebra/src/lq.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ LQ{T}(factors::AbstractMatrix, τ::AbstractVector) where {T} =
5858
LQ(convert(AbstractMatrix{T}, factors), convert(AbstractVector{T}, τ))
5959
# backwards-compatible constructors (remove with Julia 2.0)
6060
@deprecate(LQ{T,S}(factors::AbstractMatrix{T}, τ::AbstractVector{T}) where {T,S},
61-
LQ{T,S,typeof(τ)}(factors, τ))
61+
LQ{T,S,typeof(τ)}(factors, τ), false)
6262

6363
# iteration for destructuring into components
6464
Base.iterate(S::LQ) = (S.L, Val(:Q))

stdlib/LinearAlgebra/src/lu.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ LU{T}(factors::AbstractMatrix, ipiv::AbstractVector{<:Integer}, info::Integer) w
6464
# backwards-compatible constructors (remove with Julia 2.0)
6565
@deprecate(LU{T,S}(factors::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer},
6666
info::BlasInt) where {T,S},
67-
LU{T,S,typeof(ipiv)}(factors, ipiv, info))
67+
LU{T,S,typeof(ipiv)}(factors, ipiv, info), false)
6868

6969
# iteration for destructuring into components
7070
Base.iterate(S::LU) = (S.L, Val(:U))

stdlib/LinearAlgebra/src/qr.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ QR{T}(factors::AbstractMatrix, τ::AbstractVector) where {T} =
4949
QR(convert(AbstractMatrix{T}, factors), convert(AbstractVector{T}, τ))
5050
# backwards-compatible constructors (remove with Julia 2.0)
5151
@deprecate(QR{T,S}(factors::AbstractMatrix{T}, τ::AbstractVector{T}) where {T,S},
52-
QR{T,S,typeof(τ)}(factors, τ))
52+
QR{T,S,typeof(τ)}(factors, τ), false)
5353

5454
# iteration for destructuring into components
5555
Base.iterate(S::QR) = (S.Q, Val(:R))
@@ -126,7 +126,7 @@ QRCompactWY{S}(factors::AbstractMatrix, T::AbstractMatrix) where {S} =
126126
QRCompactWY(convert(AbstractMatrix{S}, factors), convert(AbstractMatrix{S}, T))
127127
# backwards-compatible constructors (remove with Julia 2.0)
128128
@deprecate(QRCompactWY{S,M}(factors::AbstractMatrix{S}, T::AbstractMatrix{S}) where {S,M},
129-
QRCompactWY{S,M,typeof(T)}(factors, T))
129+
QRCompactWY{S,M,typeof(T)}(factors, T), false)
130130

131131
# iteration for destructuring into components
132132
Base.iterate(S::QRCompactWY) = (S.Q, Val(:R))
@@ -219,7 +219,7 @@ QRPivoted{T}(factors::AbstractMatrix, τ::AbstractVector,
219219
# backwards-compatible constructors (remove with Julia 2.0)
220220
@deprecate(QRPivoted{T,S}(factors::AbstractMatrix{T}, τ::AbstractVector{T},
221221
jpvt::AbstractVector{<:Integer}) where {T,S},
222-
QRPivoted{T,S,typeof(τ),typeof(jpvt)}(factors, τ, jpvt))
222+
QRPivoted{T,S,typeof(τ),typeof(jpvt)}(factors, τ, jpvt), false)
223223

224224
# iteration for destructuring into components
225225
Base.iterate(S::QRPivoted) = (S.Q, Val(:R))
@@ -541,7 +541,7 @@ QRPackedQ{T}(factors::AbstractMatrix, τ::AbstractVector) where {T} =
541541
QRPackedQ(convert(AbstractMatrix{T}, factors), convert(AbstractVector{T}, τ))
542542
# backwards-compatible constructors (remove with Julia 2.0)
543543
@deprecate(QRPackedQ{T,S}(factors::AbstractMatrix{T}, τ::AbstractVector{T}) where {T,S},
544-
QRPackedQ{T,S,typeof(τ)}(factors, τ))
544+
QRPackedQ{T,S,typeof(τ)}(factors, τ), false)
545545

546546
"""
547547
QRCompactWYQ <: AbstractMatrix
@@ -564,7 +564,7 @@ QRCompactWYQ{S}(factors::AbstractMatrix, T::AbstractMatrix) where {S} =
564564
QRCompactWYQ(convert(AbstractMatrix{S}, factors), convert(AbstractMatrix{S}, T))
565565
# backwards-compatible constructors (remove with Julia 2.0)
566566
@deprecate(QRCompactWYQ{S,M}(factors::AbstractMatrix{S}, T::AbstractMatrix{S}) where {S,M},
567-
QRCompactWYQ{S,M,typeof(T)}(factors, T))
567+
QRCompactWYQ{S,M,typeof(T)}(factors, T), false)
568568

569569
QRPackedQ{T}(Q::QRPackedQ) where {T} = QRPackedQ(convert(AbstractMatrix{T}, Q.factors), convert(Vector{T}, Q.τ))
570570
AbstractMatrix{T}(Q::QRPackedQ{T}) where {T} = Q

0 commit comments

Comments
 (0)