Precompile cache: always add worklist CIs (#47924)

timholy · web-flow · commit 1f0700a29a4e · 2022-12-20T08:30:20.000-06:00
We cache only those external CodeInstances that link back to the
package being precompiled. Formerly we required a backedge;
this PRs adds any whose `specTypes` could only link back to the
package. This scoops up a few runtime-dispatched CodeInstances
and their callees.
diff --git a/src/staticdata_utils.c b/src/staticdata_utils.c
@@ -167,7 +167,7 @@ static int has_backedge_to_worklist(jl_method_instance_t *mi, htable_t *visited,
     if (jl_is_method(mod))
         mod = ((jl_method_t*)mod)->module;
     assert(jl_is_module(mod));
-    if (mi->precompiled || !jl_object_in_image((jl_value_t*)mod)) {
+    if (mi->precompiled || !jl_object_in_image((jl_value_t*)mod) || type_in_worklist(mi->specTypes)) {
         return 1;
     }
     if (!mi->backedges) {

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ static int has_backedge_to_worklist(jl_method_instance_t mi, htable_t visited,`
`167`	`167`	`if (jl_is_method(mod))`
`168`	`168`	`mod = ((jl_method_t*)mod)->module;`
`169`	`169`	`assert(jl_is_module(mod));`
`170`		`- if (mi->precompiled \|\| !jl_object_in_image((jl_value_t*)mod)) {`
	`170`	`+ if (mi->precompiled \|\| !jl_object_in_image((jl_value_t*)mod) \|\| type_in_worklist(mi->specTypes)) {`
`171`	`171`	`return 1;`
`172`	`172`	`}`
`173`	`173`	`if (!mi->backedges) {`