make @allocated x = f(...) work as before

Also add `donotdelete` to ensure the code actually runs, and `@constprop :none`.

Add `@allocated inside` and `@allocations inside`

Fixes #58780

Author: JeffBezanson

NEWS.md

@@ -60,6 +60,8 @@ New library features
 * `sort(keys(::Dict))` and `sort(values(::Dict))` now automatically collect, they previously threw ([#56978]).
 * `Base.AbstractOneTo` is added as a supertype of one-based axes, with `Base.OneTo` as its subtype ([#56902]).
 * `takestring!(::IOBuffer)` removes the content from the buffer, returning the content as a `String`.
+* New forms `@allocated inside f(...)` and `@allocations inside f(...)` to measure allocations inside
+  a function, excluding arguments and calling context ([#59278]).
 
 Standard library changes
 ------------------------

base/timing.jl

@@ -472,41 +472,47 @@ function gc_bytes()
     b[]
 end
 
-function allocated(f, args::Vararg{Any,N}) where {N}
+@constprop :none function allocated(f, args::Vararg{Any,N}) where {N}
     b0 = Ref{Int64}(0)
     b1 = Ref{Int64}(0)
     Base.gc_bytes(b0)
-    f(args...)
+    val = f(args...)
     Base.gc_bytes(b1)
+    donotdelete(val)
     return b1[] - b0[]
 end
 only(methods(allocated)).called = 0xff
 
-function allocations(f, args::Vararg{Any,N}) where {N}
+@constprop :none function allocations(f, args::Vararg{Any,N}) where {N}
+    # Note this value is unused, but without it `allocated` and `allocations`
+    # are sufficiently different that the compiler can remove allocations here
+    # that it cannot remove there, giving inconsistent numbers.
+    b1 = Ref{Int64}(0)
     stats = Base.gc_num()
-    f(args...)
+    val = f(args...)
     diff = Base.GC_Diff(Base.gc_num(), stats)
+    gc_bytes(b1)
+    donotdelete(val)
     return Base.gc_alloc_count(diff)
 end
 only(methods(allocations)).called = 0xff
 
-function is_simply_call(@nospecialize ex)
-    Meta.isexpr(ex, :call) || return false
-    for a in ex.args
-        a isa QuoteNode && continue
-        a isa Symbol && continue
-        isa_ast_node(a) || continue
-        return false
-    end
-    return true
-end
-
 """
     @allocated
 
 A macro to evaluate an expression, discarding the resulting value, instead returning the
 total number of bytes allocated during evaluation of the expression.
 
+If the expression is a function call, an effort is made to measure only allocations
+during the function, excluding any overhead from calling it and not performing
+constant propagation with the provided argument values. This mode of use is recommended.
+If you want to include those effects, i.e. measuring the call site as well,
+use the syntax `@allocated (()->f(1))()`.
+
+For more complex expressions, the code is simply run in place and therefore may see
+allocations due to the surrounding context. For example it is possible for
+`@allocated f(1)` and `@allocated x = f(1)` to give different results.
+
 See also [`@allocations`](@ref), [`@time`](@ref), [`@timev`](@ref), [`@timed`](@ref),
 and [`@elapsed`](@ref).
 
@@ -516,11 +522,46 @@ julia> @allocated rand(10^6)
 ```
 """
 macro allocated(ex)
-    if !is_simply_call(ex)
-        ex = :((() -> $ex)())
+    quote
+        Experimental.@force_compile
+        local b0 = Ref{Int64}(0)
+        local b1 = Ref{Int64}(0)
+        gc_bytes(b0)
+        local val = $(esc(ex))
+        gc_bytes(b1)
+        donotdelete(val)
+        b1[] - b0[]
+    end
+end
+
+"""
+    @allocated inside f(...)
+
+Return the number of bytes allocated during the execution of a given function,
+excluding any allocations in the argument expressions or due to the call itself.
+
+```julia-repl
+julia> @allocated identity([])
+32
+
+julia> @allocated inside identity([])
+0
+```
+
+!!! compat "Julia 1.12"
+    This macro was added in Julia 1.12.
+"""
+macro allocated(how, ex)
+    if how === :inside
+        if isexpr(ex, :call)
+            pushfirst!(ex.args, GlobalRef(Base, :allocated))
+            return esc(ex)
+        else
+            error("`@allocated inside` requires a call expression")
+        end
+    else
+        error("Unrecognized symbol argument to `@allocated`; must be `inside`")
     end
-    pushfirst!(ex.args, GlobalRef(Base, :allocated))
-    return esc(ex)
 end
 
 """
@@ -541,11 +582,46 @@ julia> @allocations rand(10^6)
     This macro was added in Julia 1.9.
 """
 macro allocations(ex)
-    if !is_simply_call(ex)
-        ex = :((() -> $ex)())
+    quote
+        Experimental.@force_compile
+        local b1 = Ref{Int64}(0)  # See note above in `allocations`
+        local stats = Base.gc_num()
+        local val = $(esc(ex))
+        local diff = Base.GC_Diff(Base.gc_num(), stats)
+        gc_bytes(b1)
+        donotdelete(val)
+        Base.gc_alloc_count(diff)
+    end
+end
+
+"""
+    @allocations inside f(...)
+
+Return the number of allocations during the execution of a given function,
+excluding any allocations in the argument expressions or due to the call itself.
+
+```julia-repl
+julia> @allocations identity([])
+1
+
+julia> @allocations inside identity([])
+0
+```
+
+!!! compat "Julia 1.12"
+    This macro was added in Julia 1.12.
+"""
+macro allocations(how, ex)
+    if how === :inside
+        if isexpr(ex, :call)
+            pushfirst!(ex.args, GlobalRef(Base, :allocations))
+            return esc(ex)
+        else
+            error("`@allocations inside` requires a call expression")
+        end
+    else
+        error("Unrecognized symbol argument to `@allocations`; must be `inside`")
     end
-    pushfirst!(ex.args, GlobalRef(Base, :allocations))
-    return esc(ex)
 end
 
 

test/boundscheck_exec.jl

@@ -350,7 +350,7 @@ if bc_opt == bc_default
         m1 === m2
     end
     no_alias_prove(1)
-    @test (@allocated no_alias_prove(5)) == 0
+    @test (@allocated (()->no_alias_prove(5))()) == 0
 end
 
 @testset "automatic boundscheck elision for iteration on some important types" begin

test/misc.jl

@@ -1544,11 +1544,13 @@ run(`$(Base.julia_cmd()) -e 'isempty(x) = true'`)
     @test Base.jit_total_bytes() >= 0
 
     # sanity check `@allocations` returns what we expect in some very simple cases.
-    # These are inside functions because `@allocations` uses `Experimental.@force_compile`
-    # so can be affected by other code in the same scope.
     @test (() -> @allocations "a")() == 0
-    @test (() -> @allocations "a" * "b")() == 0 # constant propagation
     @test (() -> @allocations "a" * Base.inferencebarrier("b"))() == 1
+    # test that you can grab the value from @allocated
+    @allocated _x = 1+2
+    @test _x === 3
+    @test (@allocated inside identity([])) == 0
+    @test (@allocations inside identity([])) == 0
 
     _lock_conflicts, _nthreads = eval(Meta.parse(read(`$(Base.julia_cmd()) -tauto -E '
         _lock_conflicts = @lock_conflicts begin