guard against isdir EACESS in completions #3877
Conversation
| completions = filter!(x -> isdir(s[1:prevind(s, first(cmp2)-i1+1)]*x), completions) | ||
| completions = filter!(completions) do x | ||
| try | ||
| isdir(s[1:prevind(s, first(cmp2)-i1+1)]*x) |
There was a problem hiding this comment.
Shouldn't this function return true or false? Does it always do that now or is the fall through returning nothing which would error in filter!?
There was a problem hiding this comment.
It throws if it doesn't have perms to stat the path
There was a problem hiding this comment.
Yes, and it should return false in that case, but right now it isn't I think?
There was a problem hiding this comment.
@vtjnash perhaps you have an opinion on what to do here?
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
Yes, the catch needs to end with a bool so that the filter doesn't error
|
Oh right, I thought @KristofferC was talking about changing the behavior of |
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
Though really I think we should later add a kwarg to these functions because this pattern is getting really annoying
Eg isdir(path, default=false)
Or default=nothing or default=throw (the current behavior) or default=Returns, or such
(cherry picked from commit 299b770)
(cherry picked from commit 299b770)
3 participants
Fixes JuliaLang/julia#54154