Improve warning testing for bad patterns #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable_logging() manipulates a global setting so it may interfere with any other concurrent tests. Instead, use the @test_logs macro to capture logs. I've also chosen to specifically test that a warning is produced here (rather than just use @test_logs min_level=Error which would be more like without_warnings()).
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 64 64
=========================================
Hits 64 64 Continue to review full report at Codecov.
|
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable_logging()manipulates a global setting so it may interfere withany other concurrent tests. Instead, use the
@test_logsmacro tocapture logs (which internally uses
with_logger).I've also chosen to specifically test that a warning is produced here
(rather than just use
@test_logs min_level=Errorwhich would be morelike
without_warnings()).CC @Keno I assume this may fix the problems you're seeing in
Basetests. I don't actually know what they were :-)