From 6422eca31fb6b704bb4a691d8e239008322f4e98 Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Sun, 30 Nov 2025 18:49:56 +0100 Subject: [PATCH 1/3] Reduce method definitions for cat of `AbstractQ`s --- src/abstractq.jl | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/abstractq.jl b/src/abstractq.jl index 6b5a6fcb..bc33da41 100644 --- a/src/abstractq.jl +++ b/src/abstractq.jl @@ -145,16 +145,14 @@ function copyto!(dest::PermutedDimsArray{T,2,perm}, src::AbstractQ) where {T,per end return dest end -# used in concatenations: Base.__cat_offset1! -Base._copy_or_fill!(A, inds, Q::AbstractQ) = (A[inds...] = collect(Q)) +Base.fill!(A, Q::AbstractQ) = copyto!(A, Q) + # overloads of helper functions Base.cat_size(A::AbstractQ) = size(A) Base.cat_size(A::AbstractQ, d) = size(A, d) Base.cat_length(a::AbstractQ) = prod(size(a)) Base.cat_ndims(a::AbstractQ) = ndims(a) Base.cat_indices(A::AbstractQ, d) = axes(A, d) -Base.cat_similar(A::AbstractQ, T::Type, shape::Tuple) = Array{T}(undef, shape) -Base.cat_similar(A::AbstractQ, T::Type, shape::Vector) = Array{T}(undef, shape...) function show(io::IO, ::MIME{Symbol("text/plain")}, Q::AbstractQ) print(io, Base.dims2string(size(Q)), ' ', summary(Q)) From 22b0301b4fc3e162672aa67a70079232b608ab4c Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Sun, 30 Nov 2025 19:15:57 +0100 Subject: [PATCH 2/3] can't use `fill!` --- src/abstractq.jl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/abstractq.jl b/src/abstractq.jl index bc33da41..9ea8f004 100644 --- a/src/abstractq.jl +++ b/src/abstractq.jl @@ -145,8 +145,9 @@ function copyto!(dest::PermutedDimsArray{T,2,perm}, src::AbstractQ) where {T,per end return dest end -Base.fill!(A, Q::AbstractQ) = copyto!(A, Q) +# used in concatenations: Base.__cat_offset1! +Base._copy_or_fill!(A, inds, Q::AbstractQ) = copyto!(view(A, inds...), Q) # overloads of helper functions Base.cat_size(A::AbstractQ) = size(A) Base.cat_size(A::AbstractQ, d) = size(A, d) From ac37ab61f71db6be4c76eb01aa72fc19b2112cf3 Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Mon, 1 Dec 2025 13:00:38 +0100 Subject: [PATCH 3/3] Update src/abstractq.jl --- src/abstractq.jl | 1 - 1 file changed, 1 deletion(-) diff --git a/src/abstractq.jl b/src/abstractq.jl index 9ea8f004..e784f5ec 100644 --- a/src/abstractq.jl +++ b/src/abstractq.jl @@ -145,7 +145,6 @@ function copyto!(dest::PermutedDimsArray{T,2,perm}, src::AbstractQ) where {T,per end return dest end - # used in concatenations: Base.__cat_offset1! Base._copy_or_fill!(A, inds, Q::AbstractQ) = copyto!(view(A, inds...), Q) # overloads of helper functions