Drop compat code for logdet(::Any) fallback from #382

Author: martinholters

README.md

@@ -120,8 +120,6 @@ Currently, the `@compat` macro supports the following syntaxes:
 
 * `isnothing` for testing if a variable is equal to `nothing` ([#29674]).
 
-* `logdet` for `Number`s ([#22629]).
-
 * `fieldcount` is equivalent to `nfields` for Julia versions 0.6 and below and is used to
   determine the number of fields in a data type ([#22350]).
 

src/Compat.jl

@@ -14,12 +14,6 @@ import Base.invokelatest
 
 include("compatmacro.jl")
 
-# https://github.com/JuliaLang/julia/pull/22629
-if VERSION < v"0.7.0-DEV.848"
-    import Base: logdet
-    logdet(A) = log(det(A))
-end
-
 # https://github.com/JuliaLang/julia/pull/22633
 if VERSION < v"0.7.0-DEV.1041"
     # these have been deprecated in Julia 0.7.0-DEV.5272; we keep them here to avoid

test/old.jl

@@ -165,3 +165,6 @@ end
 @test @inferred(ntuple(x->1, Val(3))) == (1,1,1)
 @test @inferred(ntuple(x->x, Val(0))) == ()
 @test @inferred(ntuple(x->x, Val(5))) == (1,2,3,4,5)
+
+# PR 22629
+@test logdet(0.5) == log(det(0.5))

test/runtests.jl

@@ -67,9 +67,6 @@ for x in (3.1, -17, 3//4, big(111.1), Inf)
     @test minmax(x) == (x, x)
 end
 
-# PR 22629
-@test logdet(0.5) == log(det(0.5))
-
 # PR 22633
 if VERSION < v"0.7.0-DEV.5272"
     # chol(A::UniformScaling) has been deprecated in Julia, we still test it to avoid