Drop compat code for isuppercase and friends from #516

Author: martinholters

README.md

@@ -112,9 +112,6 @@ Currently, the `@compat` macro supports the following syntaxes:
 
 * `findin(a, b)` is now `findall(in(b), a)` ([#24673]).
 
-* `isupper`, `islower`, `ucfirst` and `lcfirst` are now `isuppercase`, `islowercase`,
-  `uppercasefirst` and `lowercasefirst` ([#26442]).
-
 * `Compat.split` and `Compat.rsplit` accept `keepempty` keyword argument
   if `splitter` is given as second argument ([#26634])
 

src/Compat.jl

@@ -76,14 +76,6 @@ end
     end
 end
 
-if VERSION < v"0.7.0-DEV.4585"
-    export isuppercase, islowercase, uppercasefirst, lowercasefirst
-    const isuppercase = isupper
-    const islowercase = islower
-    const uppercasefirst = ucfirst
-    const lowercasefirst = lcfirst
-end
-
 if VERSION < v"0.7.0-DEV.4064"
     for f in (:mean, :median, :var, :varm, :std, :cov, :cor)
         @eval import .Statistics: $f # compatibility with old Compat versions

test/old.jl

@@ -859,3 +859,11 @@ end
 
 # 0.7.0-DEV.3972
 @test Compat.indexin([1, 2], [1, 0, 1]) == [1, nothing]
+
+# 0.7.0-DEV.4585
+@test isuppercase('A')
+@test !isuppercase('a')
+@test islowercase('a')
+@test !islowercase('A')
+@test uppercasefirst("qwerty") == "Qwerty"
+@test lowercasefirst("Qwerty") == "qwerty"

test/runtests.jl

@@ -89,14 +89,6 @@ if VERSION < v"0.7.0-DEV.4592"
     @test findall(occursin([1, 2]), [1]) == [1]
 end
 
-# 0.7.0-DEV.4585
-@test isuppercase('A')
-@test !isuppercase('a')
-@test islowercase('a')
-@test !islowercase('A')
-@test uppercasefirst("qwerty") == "Qwerty"
-@test lowercasefirst("Qwerty") == "qwerty"
-
 # 0.7.0-DEV.4064
 # some tests are behind a version check below because Julia gave
 # the wrong result between 0.7.0-DEV.3262 and 0.7.0-DEV.4646