Skip to content

Commit 88c2761

Browse files
committed
Drop compat code for Compat.names from #493 and #505
1 parent 0769ad1 commit 88c2761

File tree

4 files changed

+8
-15
lines changed

4 files changed

+8
-15
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ Currently, the `@compat` macro supports the following syntaxes:
7373

7474
* Three-argument methods `prevind(s,i,n)`, `nextind(s,i,n)` ([#23805]), and `length(s,i,j)` ([#24999]); the latter two replace `chr2ind` and `ind2chr` in Julia 0.7, respectively.
7575

76-
* `Compat.names` supporting keyword arguments for `all` and `imported` ([#25647]).
77-
7876
* `Compat.IOBuffer` supporting keyword arguments ([#25873]).
7977

8078
* `Compat.range` supporting positional and keyword arguments flavors ([#25896]), ([#28708]).

src/Compat.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,6 @@ end
7575
end
7676
end
7777

78-
# https://github.com/JuliaLang/julia/pull/25647
79-
@static if VERSION < v"0.7.0-DEV.3526"
80-
names(m; all=false, imported=false) = Base.names(m, all, imported)
81-
end
82-
8378
if VERSION >= v"0.7.0-DEV.3666"
8479
import UUIDs
8580
else

test/old.jl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -768,3 +768,11 @@ end
768768

769769
@test repr("text/plain", "string") == "\"string\"" #25990
770770
@test showable("text/plain", 3.14159) #26089
771+
772+
# 0.7.0-DEV.3526
773+
module TestNames
774+
export foo
775+
function bar end
776+
end
777+
@test :foo in Compat.names(TestNames)
778+
@test :bar in Compat.names(TestNames, all=true)

test/runtests.jl

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,6 @@ module TestUUIDs
104104
@test uuid4() isa UUID
105105
end
106106

107-
# 0.7.0-DEV.3526
108-
module TestNames
109-
export foo
110-
function bar end
111-
end
112-
@test :foo in Compat.names(TestNames)
113-
@test :bar in Compat.names(TestNames, all=true)
114-
115107
# 0.7.0-DEV.4804
116108
@test Compat.trunc(pi) == 3.0
117109
@test Compat.floor(pi) == 3.0

0 commit comments

Comments
 (0)