Extend stack from Base/Compat
#3120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to Julia in PR 43334, added to Compat in PR 777 (v4.2).
bkamins
reviewed
Aug 21, 2022
bkamins
approved these changes
Aug 21, 2022
Member
bkamins
left a comment
bkamins
left a comment
There was a problem hiding this comment.
Looks good apart from DataFrames.jl version. Should be merged after Compat.jl is released.
Co-authored-by: Bogumił Kamiński <[email protected]>
Member
Author
|
Compat v4.2.0 is now merged to General so I closed and reopened to restart CI so that it will pick up that version. |
bkamins
reviewed
Aug 21, 2022
Co-authored-by: Bogumił Kamiński <[email protected]>
Member
Author
|
Looks like the Windows failures on CI are OOMs. |
Member
|
Thank you! |
Member
|
CC @nalimilan |
Member
|
Shouldn't we always export |
Member
Author
|
Indeed, it shouldn't make a difference since Base exports it. In this case, I just made it follow suit with how we're handling other conditional extensions; those aren't unconditionally listed among the exports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to Julia in JuliaLang/julia#43334, added to Compat in JuliaLang/Compat.jl#777 (v4.2). This PR requires the latter to be merged and tagged first.
Closes #3119.