From 64e3cc94ca9548aeb88a09e8c3e5896f6f2bb807 Mon Sep 17 00:00:00 2001 From: Jameson Nash Date: Thu, 20 Jun 2024 14:13:45 -0400 Subject: [PATCH 1/5] Set BUILDKITE_CANCEL_SIGNAL to SIGQUIT for build and test --- pipelines/main/platforms/build_linux.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/pipelines/main/platforms/build_linux.yml b/pipelines/main/platforms/build_linux.yml index 981d37327..a644c8eb5 100644 --- a/pipelines/main/platforms/build_linux.yml +++ b/pipelines/main/platforms/build_linux.yml @@ -34,3 +34,4 @@ steps: TRIPLET: "${TRIPLET?}" MAKE_FLAGS: "${MAKE_FLAGS?}" ROOTFS_IMAGE_NAME: "${ROOTFS_IMAGE_NAME?}" + BUILDKITE_CANCEL_SIGNAL: "SIGQUIT" From 0d498dbe8265b47e31bca186acab223978543b43 Mon Sep 17 00:00:00 2001 From: Jameson Nash Date: Fri, 21 Jun 2024 15:09:13 +0000 Subject: [PATCH 2/5] add coredump signal and coredump uploader to all *nix builds and tests --- pipelines/main/platforms/build_freebsd.yml | 5 +++++ pipelines/main/platforms/build_linux.yml | 4 ++++ pipelines/main/platforms/build_macos.yml | 5 +++++ pipelines/main/platforms/test_freebsd.yml | 1 + pipelines/main/platforms/test_linux.i686.yml | 1 + pipelines/main/platforms/test_linux.yml | 1 + pipelines/main/platforms/test_macos.yml | 1 + 7 files changed, 18 insertions(+) diff --git a/pipelines/main/platforms/build_freebsd.yml b/pipelines/main/platforms/build_freebsd.yml index 857f0b899..59b67ac5f 100644 --- a/pipelines/main/platforms/build_freebsd.yml +++ b/pipelines/main/platforms/build_freebsd.yml @@ -4,6 +4,10 @@ steps: - label: ":freebsd: build ${TRIPLET?}" key: "build_${TRIPLET?}" plugins: + - JuliaCI/coreupload#v2: + core_pattern: "**/*.core" + compressor: "zstd" + create_bundle: "true" - JuliaCI/external-buildkite#v1: version: "./.buildkite-external-version" repo_url: "https://github.com/JuliaCI/julia-buildkite" @@ -19,3 +23,4 @@ steps: # Receive some environment mappings from our templating engine TRIPLET: "${TRIPLET?}" MAKE_FLAGS: "${MAKE_FLAGS?}" + BUILDKITE_CANCEL_SIGNAL: "SIGQUIT" diff --git a/pipelines/main/platforms/build_linux.yml b/pipelines/main/platforms/build_linux.yml index a644c8eb5..a030f11cf 100644 --- a/pipelines/main/platforms/build_linux.yml +++ b/pipelines/main/platforms/build_linux.yml @@ -4,6 +4,10 @@ steps: - label: ":linux: build ${TRIPLET?}" key: "build_${TRIPLET?}" plugins: + - JuliaCI/coreupload#v2: + core_pattern: "**/*.core" + compressor: "zstd" + create_bundle: "true" - JuliaCI/external-buildkite#v1: version: "./.buildkite-external-version" repo_url: "https://github.com/JuliaCI/julia-buildkite" diff --git a/pipelines/main/platforms/build_macos.yml b/pipelines/main/platforms/build_macos.yml index 4c4037153..723feff1f 100644 --- a/pipelines/main/platforms/build_macos.yml +++ b/pipelines/main/platforms/build_macos.yml @@ -4,6 +4,10 @@ steps: - label: ":macos: build ${TRIPLET?}" key: "build_${TRIPLET?}" plugins: + - JuliaCI/coreupload#v2: + core_pattern: "**/*.core" + compressor: "zstd" + create_bundle: "true" - JuliaCI/external-buildkite#v1: version: "./.buildkite-external-version" repo_url: "https://github.com/JuliaCI/julia-buildkite" @@ -18,3 +22,4 @@ steps: # Receive some environment mappings from our templating engine TRIPLET: "${TRIPLET?}" MAKE_FLAGS: "${MAKE_FLAGS?}" + BUILDKITE_CANCEL_SIGNAL: "SIGQUIT" diff --git a/pipelines/main/platforms/test_freebsd.yml b/pipelines/main/platforms/test_freebsd.yml index ce8631f78..83e7ce580 100644 --- a/pipelines/main/platforms/test_freebsd.yml +++ b/pipelines/main/platforms/test_freebsd.yml @@ -24,3 +24,4 @@ steps: env: JULIA_SHELL: "/usr/local/bin/bash" TRIPLET: "${TRIPLET?}" + BUILDKITE_CANCEL_SIGNAL: "SIGQUIT" diff --git a/pipelines/main/platforms/test_linux.i686.yml b/pipelines/main/platforms/test_linux.i686.yml index f7ec9c9b7..50eb03540 100644 --- a/pipelines/main/platforms/test_linux.i686.yml +++ b/pipelines/main/platforms/test_linux.i686.yml @@ -42,3 +42,4 @@ steps: TRIPLET: "${TRIPLET?}" USE_RR: "${USE_RR?}" i686_GROUP: "${i686_GROUP?}" + BUILDKITE_CANCEL_SIGNAL: "SIGQUIT" diff --git a/pipelines/main/platforms/test_linux.yml b/pipelines/main/platforms/test_linux.yml index 6a69db818..3e338b6c8 100644 --- a/pipelines/main/platforms/test_linux.yml +++ b/pipelines/main/platforms/test_linux.yml @@ -41,3 +41,4 @@ steps: JULIA_SHELL: "/bin/bash" TRIPLET: "${TRIPLET?}" USE_RR: "${USE_RR?}" + BUILDKITE_CANCEL_SIGNAL: "SIGQUIT" diff --git a/pipelines/main/platforms/test_macos.yml b/pipelines/main/platforms/test_macos.yml index fd6384840..345ca3b79 100644 --- a/pipelines/main/platforms/test_macos.yml +++ b/pipelines/main/platforms/test_macos.yml @@ -25,3 +25,4 @@ steps: env: JULIA_SHELL: "/bin/bash" TRIPLET: "${TRIPLET?}" + BUILDKITE_CANCEL_SIGNAL: "SIGQUIT" From 37edd5834e72f93a26b6af8753f42512ed76dce5 Mon Sep 17 00:00:00 2001 From: Elliot Saba Date: Fri, 21 Jun 2024 22:06:51 -0700 Subject: [PATCH 3/5] Bump linux build images to v7.3 This should get us `zstd`, for core uploading --- pipelines/main/platforms/build_linux.arches | 14 +++++++------- .../main/platforms/build_linux.soft_fail.arches | 4 ++-- .../scheduled/platforms/build_linux.no_gpl.arches | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/pipelines/main/platforms/build_linux.arches b/pipelines/main/platforms/build_linux.arches index 8d9268b06..78404bdb5 100644 --- a/pipelines/main/platforms/build_linux.arches +++ b/pipelines/main/platforms/build_linux.arches @@ -1,10 +1,10 @@ -# ROOTFS_IMAGE_NAME TRIPLET ARCH ARCH_ROOTFS MAKE_FLAGS TIMEOUT ROOTFS_TAG ROOTFS_HASH -package_linux i686-linux-gnu x86_64 i686 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v6.00 a0c4756ee7827b3a75d4a62ff543315c1547e3d6 -package_linux x86_64-linux-gnu x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v6.00 4dcde853eb5baaa0a8f087b633eaf955dc94b5dc -package_linux x86_64-linux-gnuassert x86_64 x86_64 FORCE_ASSERTIONS=1,LLVM_ASSERTIONS=1,JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v6.00 4dcde853eb5baaa0a8f087b633eaf955dc94b5dc -package_linux x86_64-linux-gnuprofiling x86_64 x86_64 WITH_TRACY=1,WITH_ITTAPI=1,WITH_TIMING_COUNTS=1,JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v6.00 4dcde853eb5baaa0a8f087b633eaf955dc94b5dc -package_linux aarch64-linux-gnu aarch64 aarch64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v6.00 e32c05f36d0a5bb0f94a17d99647f0b3352a8256 -# package_musl x86_64-linux-musl x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v6.00 948ca1e496231e4c280c236a3e9bb01c95c2cda5 +# ROOTFS_IMAGE_NAME TRIPLET ARCH ARCH_ROOTFS MAKE_FLAGS TIMEOUT ROOTFS_TAG ROOTFS_HASH +package_linux i686-linux-gnu x86_64 i686 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.3 002717b31100993dd232c6b35775b3e2e6941840 +package_linux x86_64-linux-gnu x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.3 d8de9e0051c5cd69f3dde8ddaefc594d0a71043b +package_linux x86_64-linux-gnuassert x86_64 x86_64 FORCE_ASSERTIONS=1,LLVM_ASSERTIONS=1,JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.3 d8de9e0051c5cd69f3dde8ddaefc594d0a71043b +package_linux x86_64-linux-gnuprofiling x86_64 x86_64 WITH_TRACY=1,WITH_ITTAPI=1,WITH_TIMING_COUNTS=1,JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.3 d8de9e0051c5cd69f3dde8ddaefc594d0a71043b +package_linux aarch64-linux-gnu aarch64 aarch64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . . v7.3 d39fb11781df9b03e448ad9318df2d195a3acf26 +# package_musl x86_64-linux-musl x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.3 0566496527284ed8b638273babbb5735b44d2b7e # These special lines allow us to embed default values for the columns above. # Any column without a default mapping here will simply substitute a `.` to the empty string diff --git a/pipelines/main/platforms/build_linux.soft_fail.arches b/pipelines/main/platforms/build_linux.soft_fail.arches index 430ba5e69..1d1dbcfb1 100644 --- a/pipelines/main/platforms/build_linux.soft_fail.arches +++ b/pipelines/main/platforms/build_linux.soft_fail.arches @@ -1,6 +1,6 @@ # ROOTFS_IMAGE_NAME TRIPLET ARCH ARCH_ROOTFS MAKE_FLAGS TIMEOUT ROOTFS_TAG ROOTFS_HASH -# package_musl x86_64-linux-musl x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v6.00 948ca1e496231e4c280c236a3e9bb01c95c2cda5 -package_linux x86_64-linux-gnummtk x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror,WITH_THIRD_PARTY_GC=mmtk,MMTK_PLAN=Immix,MMTK_MOVING=0 . v6.00 4dcde853eb5baaa0a8f087b633eaf955dc94b5dc +# package_musl x86_64-linux-musl x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.3 0566496527284ed8b638273babbb5735b44d2b7e +package_linux x86_64-linux-gnummtk x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror,WITH_THIRD_PARTY_GC=mmtk,MMTK_PLAN=Immix,MMTK_MOVING=0 . v7.3 0566496527284ed8b638273babbb5735b44d2b7e # package_linux armv7l-linux-gnueabihf armv7l armv7l . . ---- ---------------------------------------- diff --git a/pipelines/scheduled/platforms/build_linux.no_gpl.arches b/pipelines/scheduled/platforms/build_linux.no_gpl.arches index f8c585bbc..8a8791e40 100644 --- a/pipelines/scheduled/platforms/build_linux.no_gpl.arches +++ b/pipelines/scheduled/platforms/build_linux.no_gpl.arches @@ -1,5 +1,5 @@ # ROOTFS_IMAGE_NAME TRIPLET ARCH ARCH_ROOTFS MAKE_FLAGS TIMEOUT ROOTFS_TAG ROOTFS_HASH -package_linux x86_64-linux-gnunogpl x86_64 x86_64 USE_GPL_LIBS=0,JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v6.00 4dcde853eb5baaa0a8f087b633eaf955dc94b5dc +package_linux x86_64-linux-gnunogpl x86_64 x86_64 USE_GPL_LIBS=0,JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.3 d8de9e0051c5cd69f3dde8ddaefc594d0a71043b # These special lines allow us to embed default values for the columns above. # Any column without a default mapping here will simply substitute a `.` to the empty string From 2b1b6909716bc81768c927fe5a885937c3d414dd Mon Sep 17 00:00:00 2001 From: Elliot Saba Date: Fri, 21 Jun 2024 22:07:11 -0700 Subject: [PATCH 4/5] FreeBSD can't handle `create_bundle` --- pipelines/main/platforms/build_freebsd.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/pipelines/main/platforms/build_freebsd.yml b/pipelines/main/platforms/build_freebsd.yml index 59b67ac5f..c9390a28f 100644 --- a/pipelines/main/platforms/build_freebsd.yml +++ b/pipelines/main/platforms/build_freebsd.yml @@ -6,8 +6,6 @@ steps: plugins: - JuliaCI/coreupload#v2: core_pattern: "**/*.core" - compressor: "zstd" - create_bundle: "true" - JuliaCI/external-buildkite#v1: version: "./.buildkite-external-version" repo_url: "https://github.com/JuliaCI/julia-buildkite" From d9e925b93fd25c55ad78b66cfcb9ce82dbcb4860 Mon Sep 17 00:00:00 2001 From: Elliot Saba Date: Mon, 12 Aug 2024 16:44:10 -0700 Subject: [PATCH 5/5] Upgrade musl builder to include `file` --- pipelines/main/platforms/build_linux.soft_fail.arches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pipelines/main/platforms/build_linux.soft_fail.arches b/pipelines/main/platforms/build_linux.soft_fail.arches index 1d1dbcfb1..bd0a48fad 100644 --- a/pipelines/main/platforms/build_linux.soft_fail.arches +++ b/pipelines/main/platforms/build_linux.soft_fail.arches @@ -1,6 +1,6 @@ # ROOTFS_IMAGE_NAME TRIPLET ARCH ARCH_ROOTFS MAKE_FLAGS TIMEOUT ROOTFS_TAG ROOTFS_HASH -# package_musl x86_64-linux-musl x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.3 0566496527284ed8b638273babbb5735b44d2b7e -package_linux x86_64-linux-gnummtk x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror,WITH_THIRD_PARTY_GC=mmtk,MMTK_PLAN=Immix,MMTK_MOVING=0 . v7.3 0566496527284ed8b638273babbb5735b44d2b7e +# package_musl x86_64-linux-musl x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror . v7.6 ee00851bfbd742f895a7c5c94d5369abe88ffcbc +package_linux x86_64-linux-gnummtk x86_64 x86_64 JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror,WITH_THIRD_PARTY_GC=mmtk,MMTK_PLAN=Immix,MMTK_MOVING=0 . v7.6 ee00851bfbd742f895a7c5c94d5369abe88ffcbc # package_linux armv7l-linux-gnueabihf armv7l armv7l . . ---- ----------------------------------------