Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Feb 9, 2021

This util method is not necessary anymore, as no_offset_view is equivalent to it. This also adds a methods to _no_offset_view to ignore AbstractUnitRanges with Base.OneTo axes and not convert these to UnitRanges. This means types such as Base.OneTo will be preserved.

julia> OffsetArrays.no_offset_view(Base.OneTo(4)) |> typeof
Base.OneTo{Int64}

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #199 (5446df7) into master (3b5b11b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   98.26%   98.25%   -0.01%     
==========================================
  Files           5        5              
  Lines         288      287       -1     
==========================================
- Hits          283      282       -1     
  Misses          5        5              
Impacted Files Coverage Δ
src/utils.jl 100.00% <ø> (ø)
src/OffsetArrays.jl 97.95% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5b11b...5446df7. Read the comment docs.

@jishnub jishnub merged commit 3a9b52f into JuliaArrays:master Feb 9, 2021
@jishnub jishnub deleted the unwrap branch February 9, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants