Skip to content

Commit 67fc055

Browse files
committed
increase coverage
1 parent 3e706b4 commit 67fc055

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

src/fillbroadcast.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,6 @@ _broadcasted_zeros(f, a, b) = Zeros{Base.Broadcast.combine_eltypes(f, (a, b))}(b
102102
_broadcasted_ones(f, a, b) = Ones{Base.Broadcast.combine_eltypes(f, (a, b))}(broadcast_shape(axes(a), axes(b)))
103103
_broadcasted_nan(f, a, b) = Fill(convert(Base.Broadcast.combine_eltypes(f, (a, b)), NaN), broadcast_shape(axes(a), axes(b)))
104104

105-
# TODO: remove at next breaking version
106-
_broadcasted_zeros(a, b) = _broadcasted_zeros(+, a, b)
107-
_broadcasted_ones(a, b) = _broadcasted_ones(+, a, b)
108-
109105
broadcasted(::DefaultArrayStyle, ::typeof(+), a::Zeros, b::Zeros) = _broadcasted_zeros(+, a, b)
110106
broadcasted(::DefaultArrayStyle, ::typeof(+), a::Ones, b::Zeros) = _broadcasted_ones(+, a, b)
111107
broadcasted(::DefaultArrayStyle, ::typeof(+), a::Zeros, b::Ones) = _broadcasted_ones(+, a, b)

test/runtests.jl

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ include("infinitearrays.jl")
2929
@test convert(AbstractArray,Z) Z
3030
@test convert(AbstractArray{T},Z) AbstractArray{T}(Z) Z
3131
@test convert(AbstractVector{T},Z) AbstractVector{T}(Z) Z
32+
@test convert(AbstractFill{T},Z) AbstractFill{T}(Z) Z
3233

3334
@test $Typ{T,1}(2ones(T,5)) == Z
3435
@test $Typ{T}(2ones(T,5)) == Z
@@ -552,6 +553,7 @@ end
552553
@test randn(5) * transpose(Zeros(6)) randn(5,1) * transpose(Zeros(6)) Zeros(5,6)
553554
@test Zeros(5) * transpose(randn(6)) Zeros(5,6)
554555
@test transpose(randn(5)) * Zeros(5) 0.0
556+
@test transpose(randn(5) .+ im) * Zeros(5) 0.0 + 0im
555557

556558
@test transpose([[1,2]]) * Zeros{SVector{2,Int}}(1) 0
557559
@test_broken transpose([[1,2,3]]) * Zeros{SVector{2,Int}}(1)
@@ -619,12 +621,13 @@ end
619621

620622
@testset "Tests for ranges." begin
621623
X = randn(5)
622-
@test !(Zeros(5) + X === X)
623-
@test Zeros{Int}(5) + (1:5) === (1:5) && (1:5) + Zeros{Int}(5) === (1:5)
624-
@test Zeros(5) + (1:5) === (1.0:1.0:5.0) && (1:5) + Zeros(5) === (1.0:1.0:5.0)
625-
@test (1:5) - Zeros{Int}(5) === (1:5)
626-
@test Zeros{Int}(5) - (1:5) === -1:-1:-5
627-
@test Zeros(5) - (1:5) === -1.0:-1.0:-5.0
624+
@test !(Zeros(5) + X X)
625+
@test Zeros{Int}(5) + (1:5) (1:5) + Zeros{Int}(5) (1:5)
626+
@test Zeros(5) + (1:5) (1:5) + Zeros(5) (1.0:1.0:5.0)
627+
@test (1:5) - Zeros{Int}(5) (1:5)
628+
@test Zeros{Int}(5) - (1:5) -1:-1:-5
629+
@test Zeros(5) - (1:5) -1.0:-1.0:-5.0
630+
@test Zeros{Int}(5) + (1.0:5) (1.0:5) + Zeros{Int}(5) 1.0:5
628631
end
629632

630633
@testset "test Base.zero" begin
@@ -778,6 +781,8 @@ end
778781
@test broadcast(*, rnge, Zeros(10, 10)) Zeros{Float64}(10, 10)
779782
@test broadcast(*, Ones{Int}(10), rnge) rnge
780783
@test broadcast(*, rnge, Ones{Int}(10)) rnge
784+
@test broadcast(*, Ones(10), -5:4) broadcast(*, -5:4, Ones(10)) rnge
785+
@test broadcast(*, Ones(10), -5:1:4) broadcast(*, -5:1:4, Ones(10)) rnge
781786
@test_throws DimensionMismatch broadcast(*, Fill(5.0, 11), rnge)
782787
@test broadcast(*, rnge, Fill(5.0, 10)) == broadcast(*, rnge, 5.0)
783788
@test_throws DimensionMismatch broadcast(*, rnge, Fill(5.0, 11))

0 commit comments

Comments
 (0)