Skip to content

Conversation

@ranocha
Copy link
Contributor

@ranocha ranocha commented Nov 2, 2021

Closes #224 (more details are available in that issue).

When this PR is merged, it would be great to get a new release of ArrayInterface.jl.

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #225 (f077046) into master (921bdcd) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   87.71%   87.81%   +0.10%     
==========================================
  Files          11       11              
  Lines        1782     1789       +7     
==========================================
+ Hits         1563     1571       +8     
+ Misses        219      218       -1     
Impacted Files Coverage Δ
src/axes.jl 94.15% <100.00%> (+0.95%) ⬆️
src/indexing.jl 76.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 921bdcd...f077046. Read the comment docs.

Copy link
Collaborator

@chriselrod chriselrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chriselrod chriselrod merged commit 0b5e133 into JuliaArrays:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v3.1.37 broke axes(A::SubArray, dim) with dim larger than ndims(A)

2 participants