Skip to content

Commit d296961

Browse files
authored
Merge pull request #58 from JuliaAI/get-rid-of-static
Get rid of deprecated method `is_static`
2 parents 3418f9c + 73e9446 commit d296961

File tree

4 files changed

+1
-30
lines changed

4 files changed

+1
-30
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
authors = ["Anthony D. Blaom <[email protected]>"]
22
name = "LearnAPI"
33
uuid = "92ad9a40-7767-427a-9ee6-6e577f1266cb"
4-
version = "2.0.0"
4+
version = "2.0.1"
55

66
[compat]
77
Preferences = "1.5.0"

docs/src/traits.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ In the examples column of the table below, `Continuous` is a name owned the pack
3131
| [`LearnAPI.data_interface`](@ref)`(learner)` | Interface implemented by objects returned by [`obs`](@ref) | `Base.HasLength()` (supports `MLCore.getobs/numobs`) | `Base.SizeUnknown()` (supports `iterate`) |
3232
| [`LearnAPI.fit_scitype`](@ref)`(learner)` | upper bound on `scitype(data)` ensuring `fit(learner, data)` works | `Union{}` | `Tuple{AbstractVector{Continuous}, Continuous}` |
3333
| [`LearnAPI.target_observation_scitype`](@ref)`(learner)` | upper bound on the scitype of each observation of the targget | `Any` | `Continuous` |
34-
| [`LearnAPI.is_static`](@ref)`(learner)` | `true` if `fit` consumes no data | `false` | `true` |
3534

3635
### Derived Traits
3736

@@ -109,7 +108,6 @@ LearnAPI.data_interface
109108
LearnAPI.iteration_parameter
110109
LearnAPI.fit_scitype
111110
LearnAPI.target_observation_scitype
112-
LearnAPI.is_static
113111
```
114112

115113
```@docs

src/traits.jl

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -389,32 +389,6 @@ tables, and tuples of these. See the doc-string for details.
389389
"""
390390
data_interface(::Any) = LearnAPI.RandomAccess()
391391

392-
"""
393-
LearnAPI.is_static(learner)
394-
395-
Returns `true` if [`fit`](@ref) is called with no data arguments, as in
396-
`fit(learner)`. That is, `learner` does not generalize to new data, and data is only
397-
provided at the `predict` or `transform` step.
398-
399-
For example, some clustering algorithms are applied with this workflow, to assign labels
400-
to the observations in `X`:
401-
402-
```julia
403-
model = fit(learner) # no training data
404-
labels = predict(model, X) # may mutate `model`!
405-
406-
# extract some byproducts of the clustering algorithm (e.g., outliers):
407-
LearnAPI.extras(model)
408-
```
409-
410-
# New implementations
411-
412-
This trait, falling back to `false`, may only be overloaded when `fit` has no data
413-
arguments. See more at [`fit`](@ref).
414-
415-
"""
416-
is_static(::Any) = false
417-
418392
"""
419393
LearnAPI.iteration_parameter(learner)
420394

test/traits.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ small = SmallLearner()
4646
@test LearnAPI.data_interface(small) == LearnAPI.RandomAccess()
4747
@test !(6 isa LearnAPI.fit_scitype(small))
4848
@test 6 isa LearnAPI.target_observation_scitype(small)
49-
@test !LearnAPI.is_static(small)
5049

5150
# DERIVED TRAITS
5251

0 commit comments

Comments
 (0)