Skip to content
This repository was archived by the owner on May 25, 2025. It is now read-only.

Commit fc3dd0b

Browse files
committed
Address PR comments
1 parent 27725dd commit fc3dd0b

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

bin/create-action.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ const getActionMetadata = async () => {
6666
type: 'autocomplete',
6767
name: 'icon',
6868
message: 'Choose an icon for your action. Visit https://feathericons.com for a visual reference.',
69-
choices: icons
69+
choices: icons,
70+
limit: 10
7071
},
7172
{
7273
type: 'autocomplete',
@@ -128,13 +129,7 @@ const createAction = async (argv) => {
128129
const directoryName = args._[0]
129130
if (!directoryName || args.help) {
130131
console.log(`\nUsage: npx actions-toolkit <name>`)
131-
process.exit(1)
132-
// Although this return is unreachable,
133-
// for some reason, code after this block is reached in unit tests,
134-
// even while this calls `process.exit(1)`.
135-
// Adding a `return` below fixes that issue in the tests.
136-
// eslint-disable-next-line
137-
return
132+
return process.exit(1)
138133
}
139134
const base = path.join(process.cwd(), directoryName)
140135
try {

bin/template/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ FROM node:slim
1313
# Labels for GitHub to read your action
1414
LABEL "com.github.actions.name"=":NAME"
1515
LABEL "com.github.actions.description"=":DESCRIPTION"
16-
# Here all of the available icons: https://feathericons.com/
16+
# Here are all of the available icons: https://feathericons.com/
1717
LABEL "com.github.actions.icon"=":ICON"
1818
# And all of the available colors: https://developer.github.com/actions/creating-github-actions/creating-a-docker-container/#label
1919
LABEL "com.github.actions.color"=":COLOR"

tests/__snapshots__/create-action.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ FROM node:slim
1616
# Labels for GitHub to read your action
1717
LABEL "com.github.actions.name"="My Project Name"
1818
LABEL "com.github.actions.description"="A cool project"
19-
# Here all of the available icons: https://feathericons.com/
19+
# Here are all of the available icons: https://feathericons.com/
2020
LABEL "com.github.actions.icon"="anchor"
2121
# And all of the available colors: https://developer.github.com/actions/creating-github-actions/creating-a-docker-container/#label
2222
LABEL "com.github.actions.color"="blue"

0 commit comments

Comments
 (0)