This repository was archived by the owner on Dec 11, 2022. It is now read-only.
SAC algorithm #282
Merged
SAC algorithm #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix problem in gradient calculation. Now SAC agents is able to train. gym_environment - fixing an error in access to gym.spaces
shadiendrawis
approved these changes
Apr 24, 2019
Contributor
|
@galnov can you review that everything is in order in terms of documentation, everything else should be ready for merge. |
galnov
previously requested changes
Apr 28, 2019
Contributor
galnov
left a comment
galnov
left a comment
There was a problem hiding this comment.
In addition to the inline comments, please note that humanoid training using the preset fails.
rl_coach/architectures/tensorflow_components/heads/sac_q_head.py
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.