[WIP] Disable heart rate tracking while power is connected (charging) #2376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not appear to actually disable heart rate monitoring. I think it may be worth adding new message states to communicate to the heart rate task via
SystemTask.cpp.Conceptually, the idea here was to force the task into a waiting state if the battery controller indicated power was present.
A similar idea would apply to the step tracker. I did not add a boolean flag to control whether this feature was on or off, but conceptually if someone built an external wearable battery or charger then this would be incomplete.
See #2369
Edit: Do not use as is in 0e67cff, this introduces a crash when the heart rate setting is turned on in the heart rate app.