Added active alarm indicator to watch face #2355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
Contributor
|
Excuse me if I misunderstand this PR, but isn't it essentially a duplicate of the already merged #1884? |
Author
|
I missed that it is already merged, since I did not happen to see it mentioned anywhere on the issue page also the simulator (InfiniSim) did not have that functionality. Also I went through pr #1884 now, it did only provide support over 'DigitalWatchFace' and not the other watch face styles. I have made changes onto what is required as of now. |
Paarth-Shirsat
force-pushed
the
alarm-indicator-addition
branch
from
886a1fc to
3f7c049
Compare
Paarth-Shirsat
force-pushed
the
alarm-indicator-addition
branch
from
3b0cc8e to
b51f571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
This pull request aims to solve the issue #2075, in which it was expected to add an 'Active Alarm Indicator' on the Watch Face so as to allow the user to see if alarm is set or not and to improve the user's overall experience.
Screenshots
Following are several images of the Alarm Indicator in action for various watch faces.
Digital Watch Face: Alarm Active
Digital Watch Face: Alarm Inactive
Analog Watch Face: Alarm Active
Analog Watch Face: Alarm Inactive
PineTimeStyle Watch Face: Alarm Active
PineTimeStyle Watch Face: Alarm Inactive
Terminal Watch Face: Alarm Active (12 H mode)
Terminal Watch Face: Alarm Active (24 H mode)
Terminal Watch Face: Alarm Inactive
For the simulation and testing I used the 'InfiniSim' repository. Tried to keep the design sleek and clean.
Code Changes
Added the functionality by implementing alarm icons using lvgl and fetching data using alarmController on each watch face.