Skip to content

BatteryIcon: Change color with charge percentage #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BatteryIcon: Change color with charge percentage #1964

wants to merge 1 commit into from

Conversation

@vkareh
Copy link
Contributor

@vkareh vkareh commented Jan 13, 2024 •
edited
Loading

Silly little change to dynamically color the battery based on the charge left.

battery

@github-actions
Copy link

github-actions bot commented Jan 13, 2024 •
edited
Loading

Build size and comparison to main:

Section Size Difference
text 382636B 208B
data 944B 0B
bss 22632B 0B

Run in InfiniEmu

@minacode
Copy link
Contributor

minacode commented Jan 13, 2024 •
edited
Loading

Nice idea, I like it a lot! 😊
I think you could improve the contrast a little by using HSV colors and mapping the percentage to the hue interval between red and green.
The brown in the second picture would become yellow.
Lvgl can do the conversion to RGB.

@vkareh vkareh force-pushed the battery-icon-colors branch from bfaaffd to b7a6ddc Compare January 13, 2024 14:40
@vkareh
Copy link
Contributor Author

vkareh commented Jan 13, 2024

@minacode That's a brilliant suggestion! I've updated the code and added a new screenshot - looks way better, thanks!

@vkareh vkareh force-pushed the battery-icon-colors branch 2 times, most recently from 9eaf40e to 8e61a5d Compare January 16, 2024 21:50
@vkareh vkareh force-pushed the battery-icon-colors branch 2 times, most recently from 7083ce0 to a850f49 Compare January 24, 2024 15:32
@JustScott JustScott mentioned this pull request Feb 3, 2024
Closed
@vkareh vkareh force-pushed the battery-icon-colors branch 3 times, most recently from ec452d0 to 20a0843 Compare February 12, 2024 15:13
@vkareh vkareh force-pushed the battery-icon-colors branch 2 times, most recently from 559832f to de3ca3a Compare February 19, 2024 01:09
@z3t0
Copy link

z3t0 commented Mar 1, 2024

I love this change. Thank you.

@vkareh vkareh force-pushed the battery-icon-colors branch from de3ca3a to 7e86e85 Compare March 18, 2024 12:43
@vkareh vkareh force-pushed the battery-icon-colors branch from 7e86e85 to a238940 Compare March 26, 2024 12:14
@vkareh vkareh force-pushed the battery-icon-colors branch from a238940 to 0178441 Compare April 12, 2024 12:59
@vkareh vkareh force-pushed the battery-icon-colors branch from 0178441 to f5f160f Compare May 13, 2024 14:54
@vkareh vkareh force-pushed the battery-icon-colors branch from f5f160f to b534fa2 Compare June 10, 2024 14:32
@vkareh vkareh force-pushed the battery-icon-colors branch from b534fa2 to a570644 Compare June 19, 2024 15:29
@vkareh vkareh force-pushed the battery-icon-colors branch 2 times, most recently from 8dee72a to dfa3c8e Compare August 19, 2024 17:06
@vkareh vkareh force-pushed the battery-icon-colors branch from dfa3c8e to 1353e94 Compare August 22, 2024 15:52
@vkareh vkareh force-pushed the battery-icon-colors branch 2 times, most recently from 7a27ce7 to f39c176 Compare September 23, 2024 13:04
@vkareh vkareh force-pushed the battery-icon-colors branch from f39c176 to a9aa092 Compare October 3, 2024 12:35
JustScott added a commit to JustScott/InfiniTime that referenced this pull request Oct 3, 2024
@JustScott
Improved the Terminal Watchfaces UI
c312a6c 
+ Reorder code to match the widgets order in the UI.

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
@JustScott JustScott mentioned this pull request Oct 3, 2024
Open
JustScott added a commit to JustScott/InfiniTime that referenced this pull request Oct 4, 2024
@JustScott
Improved the Terminal Watchfaces UI
d2382e1 
+ Reorder code to match the widgets order in the UI.

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
JustScott added a commit to JustScott/InfiniTime that referenced this pull request Jan 30, 2025
@JustScott
Improved the Terminal Watchfaces UI
f51685d 
+ Reorder code to match the widgets order in the UI.

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
@vkareh vkareh force-pushed the battery-icon-colors branch from 640ece5 to a8204e0 Compare February 28, 2025 14:38
BurninTurtles pushed a commit to BurninTurtles/InfiniTimeBT that referenced this pull request Mar 3, 2025
@JustScott @BurninTurtles
Improved the Terminal Watchfaces UI
210621b 
+ Reorder code to match the widgets order in the UI.

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
BurninTurtles pushed a commit to BurninTurtles/InfiniTimeBT that referenced this pull request Mar 3, 2025
@JustScott @BurninTurtles
Improved the Terminal Watchfaces UI
d61398a 
+ Reorder code to match the widgets order in the UI.

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
BurninTurtles pushed a commit to BurninTurtles/InfiniTimeBT that referenced this pull request Mar 3, 2025
@JustScott @BurninTurtles
Improved the Terminal Watchfaces UI
be5a3af 
+ Reorder code to match the widgets order in the UI.

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
BurninTurtles pushed a commit to BurninTurtles/InfiniTimeBT that referenced this pull request Mar 3, 2025
@JustScott @BurninTurtles
Improved the Terminal Watchfaces UI
8e139ac 
+ Reorder code to match the widgets order in the UI.

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
@vkareh vkareh force-pushed the battery-icon-colors branch from a8204e0 to 2e0b92f Compare May 14, 2025 14:21
@vkareh vkareh force-pushed the battery-icon-colors branch 2 times, most recently from 9071904 to d030d75 Compare May 30, 2025 16:31
@NeroBurner NeroBurner added this to the 1.16.0 milestone May 30, 2025
@mark9064
Copy link
Member

mark9064 commented May 30, 2025

Could I suggest a colour curve such as -e^{-4x}+1 (where x is the battery between 0 and 1)? This way it only starts tinting yellow around 25% ish and is fully yellow around 15%

@vkareh vkareh force-pushed the battery-icon-colors branch from d030d75 to 1d44bce Compare June 4, 2025 17:18
@L3br4nd L3br4nd mentioned this pull request Jun 5, 2025
Open
1 task
@vkareh vkareh force-pushed the battery-icon-colors branch 2 times, most recently from 9a324fb to 1ed7ab4 Compare June 19, 2025 17:49
JustScott added a commit to JustScott/InfiniTime that referenced this pull request Jun 20, 2025
@JustScott
Improved the Terminal Watchfaces UI
56063ea 
+ Reorder code to match the widgets order in the UI.

+ Moved all objects (rows) into a container

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
JustScott added a commit to JustScott/InfiniTime that referenced this pull request Jun 21, 2025
@JustScott
Improved the Terminal Watchfaces UI
a1c9420 
+ Reorder code to match the widgets order in the UI.

+ Moved all objects (rows) into a container

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
@vkareh vkareh force-pushed the battery-icon-colors branch from 1ed7ab4 to 6942e88 Compare June 30, 2025 14:20
JustScott added a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
@JustScott
Improved the Terminal Watchfaces UI
43d1126 
+ Reorder code to match the widgets order in the UI.

+ Moved all objects (rows) into a container

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
@vkareh vkareh force-pushed the battery-icon-colors branch from 6942e88 to 587d3a3 Compare July 31, 2025 12:36
JustScott added a commit to JustScott/InfiniTime that referenced this pull request Aug 22, 2025
@JustScott
Improved the Terminal Watchfaces UI
e866b1e 
+ Reorder code to match the widgets order in the UI.

+ Moved all objects (rows) into a container

+ Use InfintimeTheme Colors instead of hardcoded hex values

+ Added a new InfinitimeTheme color: gray, using it to turn certain
  values gray when they contain no data

+ Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964)
  color to the battery percentage text.

+ Replaced the 'You have mail.' notification message with the message
  '[1]+ Notify' to better fit the terminal lore.
@vkareh vkareh force-pushed the battery-icon-colors branch from 587d3a3 to 859dd5e Compare October 3, 2025 16:07
@vkareh vkareh force-pushed the battery-icon-colors branch from 859dd5e to 870f4c2 Compare October 28, 2025 15:48
@vkareh vkareh force-pushed the battery-icon-colors branch 2 times, most recently from 36ce12c to ad59fad Compare November 7, 2025 20:41
@mark9064 mark9064 modified the milestones: 1.16.0, 1.17.0 Nov 8, 2025
@vkareh vkareh force-pushed the battery-icon-colors branch from ad59fad to 0ff9a1e Compare November 12, 2025 19:10
@vkareh vkareh force-pushed the battery-icon-colors branch from 0ff9a1e to 1cfc616 Compare November 14, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

new feature This thread is about a new feature

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vkareh @minacode @z3t0 @mark9064 @NeroBurner