fix 🐛 remove get_camera_identifier as it doesn't exist in cpp

Author: dubusster

src/python/librir/video_io/IRMovie.py

@@ -28,7 +28,6 @@
     enable_bad_pixels,
     flip_camera_calibration,
     get_attributes,
-    get_camera_identifier,
     get_emissivity,
     get_filename,
     get_global_attributes,
@@ -144,10 +143,8 @@ def __init__(self, handle):
         if get_image_count(handle) < 0:
             raise RuntimeError("Invalid ir_movie descriptor")
 
-        # consider pulse as a handle identifier
         self.handle = handle
         self.times = None
-        self._identifier = None
         self._enable_bad_pixels = False
         self._last_lines = None
         self._payload = None
@@ -292,27 +289,6 @@ def calibrations(self):
             self.handle
         )  # possible calibrations (usually 'Digital Level' and 'Temperature(C)')
 
-    @property
-    def identifier(self):
-        """
-        Stores and gives handle identifier via librir by default. If not available,
-        gives the user defined one.
-        :return: identifier (str)
-        """
-        try:
-            self._identifier = get_camera_identifier(self.handle)
-        except RuntimeError:
-            if self.handle > 0:
-                logger.warning(
-                    "'{}' is user defined identifier".format(self._identifier)
-                )
-        finally:
-            return self._identifier
-
-    @identifier.setter
-    def identifier(self, value):
-        self._identifier = value
-
     # def frame_attributes(self, frame_index):
     #     return self._file_attributes.frame_attributes(frame_index)
 

src/python/librir/video_io/rir_video_io.py

@@ -57,22 +57,6 @@ def close_camera(camera):
     _video_io.close_camera(camera)
 
 
-def get_camera_identifier(camera):
-    """
-    Returns a camera unique identifier.
-
-    C signature:
-    int get_camera_identifier(void * camera, char * identifier);
-    """
-
-    unique_identifier = np.zeros(200, dtype="c")
-    u_p = unique_identifier.ctypes.data_as(ct.POINTER(ct.c_char))
-    res = _video_io.get_camera_identifier(camera, u_p)
-    if res < 0:
-        raise RuntimeError("cannot retrieve camera identifier")
-    return toString(unique_identifier)
-
-
 def get_filename(camera):
     """Returns the camera filename (if any)"""
     fname = np.zeros(200, dtype="c")
@@ -393,7 +377,7 @@ def get_attributes(camera):
             )
         if tmp < 0:
             raise RuntimeError("An error occured while calling 'get_attributes'")
-        res[toString(key)] = toBytes(value)[0 : vlen[0]]
+        res[toString(key)] = toString(value)[0 : vlen[0]]
 
     return res