Skip to content

Commit ceadf4f

Browse files
authored
Merge pull request #1846 from wclaeys/master
Do not ignore Consumer.Offsets.AutoCommit.Enable config on Close
2 parents 80667b9 + 2b925af commit ceadf4f

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

offset_manager.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,12 @@ func (om *offsetManager) Close() error {
113113
om.asyncClosePOMs()
114114

115115
// flush one last time
116-
for attempt := 0; attempt <= om.conf.Consumer.Offsets.Retry.Max; attempt++ {
117-
om.flushToBroker()
118-
if om.releasePOMs(false) == 0 {
119-
break
116+
if om.conf.Consumer.Offsets.AutoCommit.Enable {
117+
for attempt := 0; attempt <= om.conf.Consumer.Offsets.Retry.Max; attempt++ {
118+
om.flushToBroker()
119+
if om.releasePOMs(false) == 0 {
120+
break
121+
}
120122
}
121123
}
122124

0 commit comments

Comments
 (0)