Skip to content

Commit 4bdf421

Browse files
authored
chore: remove redundant insufficient data checks (#3300)
Immediately after these checks we call `getArrayLength` which checks again. Signed-off-by: beanz <[email protected]>
1 parent 9bc3d14 commit 4bdf421

1 file changed

Lines changed: 0 additions & 13 deletions

File tree

real_decoder.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -304,10 +304,6 @@ func (rd *realDecoder) getCompactInt32Array() ([]int32, error) {
304304
}
305305

306306
func (rd *realDecoder) getInt32Array() ([]int32, error) {
307-
if rd.remaining() < 4 {
308-
rd.off = len(rd.raw)
309-
return nil, ErrInsufficientData
310-
}
311307
n, err := rd.getArrayLength()
312308
if err != nil {
313309
return nil, err
@@ -330,10 +326,6 @@ func (rd *realDecoder) getInt32Array() ([]int32, error) {
330326
}
331327

332328
func (rd *realDecoder) getInt64Array() ([]int64, error) {
333-
if rd.remaining() < 4 {
334-
rd.off = len(rd.raw)
335-
return nil, ErrInsufficientData
336-
}
337329
n, err := rd.getArrayLength()
338330
if err != nil {
339331
return nil, err
@@ -356,11 +348,6 @@ func (rd *realDecoder) getInt64Array() ([]int64, error) {
356348
}
357349

358350
func (rd *realDecoder) getStringArray() ([]string, error) {
359-
if rd.remaining() < 4 {
360-
rd.off = len(rd.raw)
361-
return nil, ErrInsufficientData
362-
}
363-
364351
n, err := rd.getArrayLength()
365352
if err != nil {
366353
return nil, err

0 commit comments

Comments
 (0)