Skip to content

Commit 055a5aa

Browse files
committed
chore: remove stylelint, enable Biome CSS linting
- Remove stylelint and stylelint-config-tailwindcss packages - Delete .stylelintrc.json and .github/workflows/stylelint.yml - Remove stylelint from CI pipelines (cicd_pipeline, cicd_pipeline_develop) - Remove stylelint from pre-commit hooks - Enable Biome CSS linter with cssModules parser support - Disable noisy CSS rules (noUnknownTypeSelector, noDescendingSpecificity) - Downgrade existing-code CSS issues to warnings for incremental fixing - Fix minor CSS parse errors (missing semicolon, stray semicolon, comma in :global) - Update lint-css script to use biome instead of stylelint Made-with: Cursor
1 parent 43eeaa1 commit 055a5aa

File tree

14 files changed

+36
-431
lines changed

14 files changed

+36
-431
lines changed

.github/workflows/cicd_pipeline.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -140,15 +140,6 @@ jobs:
140140
with:
141141
head_sha: ${{ github.event.pull_request.head.sha || github.event.after }}
142142

143-
stylelint:
144-
name: "Linter"
145-
needs:
146-
- changed_files
147-
if: needs.changed_files.outputs.frontend == 'true'
148-
uses: ./.github/workflows/stylelint.yml
149-
with:
150-
head_sha: ${{ github.event.pull_request.head.sha || github.event.after }}
151-
152143
build-frontend-docs:
153144
name: "Build"
154145
needs:
@@ -509,7 +500,6 @@ jobs:
509500
- bandit
510501
- ruff
511502
- biome
512-
- stylelint
513503
- pytest
514504
- migrations
515505
- build-docker
@@ -521,7 +511,7 @@ jobs:
521511
- name: Decide whether the needed jobs succeeded or failed
522512
uses: re-actors/alls-green@release/v1
523513
with:
524-
allowed-skips: gitleaks, bandit, ruff, biome, stylelint, pytest, migrations, conda-test, build-docker, tests-yarn-unit, tests-yarn-lsf, cursor-review
514+
allowed-skips: gitleaks, bandit, ruff, biome, pytest, migrations, conda-test, build-docker, tests-yarn-unit, tests-yarn-lsf, cursor-review
525515
allowed-failures: |
526516
[
527517
"gitleaks",

.github/workflows/cicd_pipeline_develop.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,6 @@ jobs:
3535
with:
3636
head_sha: ${{ github.event.pull_request.head.sha || github.event.after }}
3737

38-
stylelint:
39-
name: "Linter"
40-
uses: ./.github/workflows/stylelint.yml
41-
with:
42-
head_sha: ${{ github.event.pull_request.head.sha || github.event.after }}
43-
4438
build-docker:
4539
name: "Build"
4640
permissions:
@@ -122,7 +116,6 @@ jobs:
122116
- bandit
123117
- ruff
124118
- biome
125-
- stylelint
126119
- pytest
127120
- migrations
128121
- build-docker
@@ -133,5 +126,5 @@ jobs:
133126
- name: Decide whether the needed jobs succeeded or failed
134127
uses: re-actors/alls-green@release/v1
135128
with:
136-
allowed-skips: gitleaks, bandit, ruff, biome, stylelint, pytest, migrations, conda-test, build-docker, tests-yarn-unit, tests-yarn-lsf
129+
allowed-skips: gitleaks, bandit, ruff, biome, pytest, migrations, conda-test, build-docker, tests-yarn-unit, tests-yarn-lsf
137130
jobs: ${{ toJSON(needs) }}

.github/workflows/stylelint.yml

Lines changed: 0 additions & 36 deletions
This file was deleted.

.pre-commit-config.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,3 @@ repos:
1717
language: system
1818
pass_filenames: false
1919
files: ^web/.*
20-
- id: stylelint
21-
name: stylelint
22-
entry: bash -c 'cd web && npx stylelint **/*.css --fix'
23-
language: node
24-
types: [ css ]
25-
files: ^.*\.css$

.pre-commit-dev.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,3 @@ repos:
1616
language: system
1717
pass_filenames: false
1818
files: ^web/.*
19-
- id: stylelint
20-
name: stylelint
21-
entry: bash -c 'cd web && npx stylelint **/*.css --fix'
22-
language: node
23-
types: [ css ]
24-
files: ^.*\.css$

web/.stylelintrc.json

Lines changed: 0 additions & 52 deletions
This file was deleted.

web/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ To start the development server with HMR:
6565
- `yarn test:integration`: Run integration tests for all apps and libraries.
6666
- `yarn test:unit`: Run unit tests for all apps and libraries.
6767
- `yarn lint`: Run biome linter across all files with autofix.
68-
- `yarn lint-css`: Run stylelint linter across all CSS files with autofix.
68+
- `yarn lint-css`: Run Biome CSS linter across all CSS files with autofix.
6969

7070
### Git Hooks
7171
This project uses python `pre-commit` hooks to ensure code quality. To install the hooks, run `make configure-hooks` in the project root directory.

web/biome.json

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@
2626
"lineWidth": 120
2727
},
2828
"css": {
29+
"parser": {
30+
"cssModules": true
31+
},
2932
"linter": {
30-
"enabled": false
33+
"enabled": true
3134
},
3235
"formatter": {
3336
"enabled": false
@@ -55,7 +58,9 @@
5558
"noConfusingVoidType": "off",
5659
"noImplicitAnyLet": "off",
5760
"noShadowRestrictedNames": "off",
58-
"useGetterReturn": "off"
61+
"useGetterReturn": "off",
62+
"noDuplicateProperties": "warn",
63+
"noShorthandPropertyOverrides": "warn"
5964
},
6065
"complexity": {
6166
"noForEach": "off",
@@ -74,7 +79,11 @@
7479
},
7580
"noUnusedVariables": {
7681
"level": "warn"
77-
}
82+
},
83+
"noUnknownTypeSelector": "off",
84+
"noUnknownPseudoClass": "off",
85+
"noUnknownMediaFeatureName": "warn",
86+
"noUnknownProperty": "warn"
7887
},
7988
"performance": {
8089
"noAccumulatingSpread": "off",
@@ -92,7 +101,8 @@
92101
"noUnusedTemplateLiteral": "error",
93102
"useNumberNamespace": "error",
94103
"noInferrableTypes": "error",
95-
"noUselessElse": "error"
104+
"noUselessElse": "error",
105+
"noDescendingSpecificity": "off"
96106
},
97107
"nursery": {},
98108
"security": {

web/libs/app-common/src/pages/AccountSettings/sections/PersonalAccessToken.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.input {
2-
@apply flex-1 max-h-[40px]
2+
@apply flex-1 max-h-[40px];
33
}
44

55
.textarea {

web/libs/editor/src/components/Taxonomy/Taxonomy.module.css

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,6 @@
119119
line-height: 2em;
120120
}
121121

122-
;
123-
124122
.taxonomy__item {
125123
display: flex;
126124

0 commit comments

Comments
 (0)