Add workaround for Firefox video play performance issue #4210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
approved these changes
Apr 30, 2021
Contributor
netpro2k
left a comment
netpro2k
left a comment
There was a problem hiding this comment.
We should double check that this doesn't cause any issues in Firefox reality or Firefox for android but otherwise looks good to me. This is an awesomely simple "fix" to a big problem!
brianpeiris
approved these changes
May 1, 2021
Contributor
There was a problem hiding this comment.
My tests on various devices wiith a 4K video (https://brianpeiris.github.io/test-media/big-buck-bunny-4k-short.mp4):
| RGB | RGBA | |
|---|---|---|
| FF on Windows | 6fps | 60fps |
| FF on Mac | 20fps | 60fps |
| FF on Linux | 14fps | 14fps |
| FxR on Quest | 35fps | 35fps |
Firefox on Android: Could not test due to existing bug where videos don't render at all :( #4213
We should look at Android later, but the significant benefit on Windows and Mac makes this well worth it. Nice work!!
|
The best video performance I have had was with the new Microsoft Edge
browser.
60 FPS even while screen sharing a video from a tab with either Youtube or
Netflix.
I was able to use VB-Audio virtual cable as a loopback to send the audio
through the mic so it was received perfectly in Hubs.
…On Sat, May 1, 2021 at 1:00 AM Brian Peiris ***@***.***> wrote:
***@***.**** approved this pull request.
My tests on various devices wiith a 4K video:
RGB RGBA
FF on Windows 6fps 60fps
FF on Mac 20fps 60fps
FF on Linux 14fps 14fps
FxR on Quest 35fps 35fps
Firefox on Android: Could not test due to existing bug where videos don't
render at all :( #4213 <#4213>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4210 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATDKS7BG3QJMKUMYYF64SLTLODFZANCNFSM435IQSCA>
.
|
Contributor
Author
|
Thanks for the test! I would merge this PR. |
|
It works even better when Edge is capturing video from Firefox. Avoid
Chrome.
…On Mon, May 3, 2021 at 12:06 PM Takahiro ***@***.***> wrote:
Merged #4210 <#4210> into master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4210 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATDKSZXGBZK267GA5FEGPLTL3CZDANCNFSM435IQSCA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #3470 (comment) and the following comments.
Firefox seems to have video play (or decode) performance issue. The FPS number becomes very bad if videos are played in viewport on Firefox.
In Three.js repo, it has been reported that somehow setting RGBA format to video texture improves the performance very well. (I guess it can avoid slow decoding in browser?).
The ticket has been opened for the performance issue in bugzilla but I don't think it can be resolved soon. So I would like to suggest to set RGBA format for Firefox as workaround so far.
11.2MB mp4 video + desktop Windows + NVIDIA GeForce GTX 1080.
Ideally we should test on more platforms (Mac, Mobile, other graphics boards and so on). I would be happy if you test on your end, too.