Skip to content

Commit 0663d0e

Browse files
authored
Merge pull request #11 from MozillaReality/feature/object3d-component-matrixNeedsUpdate
Set matrixNeedsUpdate flag in built in components
2 parents 826d696 + e88acc6 commit 0663d0e

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

src/components/position.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@ module.exports.Component = registerComponent('position', {
77
var object3D = this.el.object3D;
88
var data = this.data;
99
object3D.position.set(data.x, data.y, data.z);
10+
object3D.matrixNeedsUpdate = true;
1011
},
1112

1213
remove: function () {
1314
// Pretty much for mixins.
1415
this.el.object3D.position.set(0, 0, 0);
16+
this.el.object3D.matrixNeedsUpdate = true;
1517
}
1618
});

src/components/rotation.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@ module.exports.Component = registerComponent('rotation', {
1212
var object3D = this.el.object3D;
1313
object3D.rotation.set(degToRad(data.x), degToRad(data.y), degToRad(data.z));
1414
object3D.rotation.order = 'YXZ';
15+
object3D.matrixNeedsUpdate = true;
1516
},
1617

1718
remove: function () {
1819
// Pretty much for mixins.
1920
this.el.object3D.rotation.set(0, 0, 0);
21+
this.el.object3D.matrixNeedsUpdate = true;
2022
}
2123
});

src/components/scale.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@ module.exports.Component = registerComponent('scale', {
1616
var y = data.y === 0 ? zeroScale : data.y;
1717
var z = data.z === 0 ? zeroScale : data.z;
1818
object3D.scale.set(x, y, z);
19+
object3D.matrixNeedsUpdate = true;
1920
},
2021

2122
remove: function () {
2223
// Pretty much for mixins.
2324
this.el.object3D.scale.set(1, 1, 1);
25+
this.el.object3D.matrixNeedsUpdate = true;
2426
}
2527
});

0 commit comments

Comments
 (0)