Revert "core/state/snapshot: be very noisy if the generator hits a trie error (ethereum#28178)"

devopsbo3 · web-flow · commit 8fd4c13cbc36 · 2023-11-10T12:27:53.000-06:00
This reverts commit 7cd6ef9.
diff --git a/core/state/snapshot/generate.go b/core/state/snapshot/generate.go
@@ -446,10 +446,6 @@ func (dl *diskLayer) generateRange(ctx *generatorContext, trieId *trie.ID, prefi
 		internal += time.Since(istart)
 	}
 	if iter.Err != nil {
-		// Trie errors should never happen. Still, in case of a bug, expose the
-		// error here, as the outer code will presume errors are interrupts, not
-		// some deeper issues.
-		log.Error("State snapshotter failed to iterate trie", "err", err)
 		return false, nil, iter.Err
 	}
 	// Delete all stale snapshot states remaining

Original file line number	Diff line number	Diff line change
`@@ -446,10 +446,6 @@ func (dl diskLayer) generateRange(ctx generatorContext, trieId *trie.ID, prefi`
`446`	`446`	`internal += time.Since(istart)`
`447`	`447`	`}`
`448`	`448`	`if iter.Err != nil {`
`449`		`- // Trie errors should never happen. Still, in case of a bug, expose the`
`450`		`- // error here, as the outer code will presume errors are interrupts, not`
`451`		`- // some deeper issues.`
`452`		`- log.Error("State snapshotter failed to iterate trie", "err", err)`
`453`	`449`	`return false, nil, iter.Err`
`454`	`450`	`}`
`455`	`451`	`// Delete all stale snapshot states remaining`