Pass Bins as const ref whenever possible #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
added
bug
MaxThevenet
commented
Mar 2, 2022
MaxThevenet
commented
Mar 2, 2022
MaxThevenet
commented
Mar 2, 2022
SeverinDiederichs
approved these changes
Mar 2, 2022
Member
SeverinDiederichs
left a comment
SeverinDiederichs
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @WeiqunZhang's comments, fix the handling of Bins in several places in the code. This appears to fix issue #686 (unless it's a random failure).