[SW-225565] Enable triangular softmax with merged prefill #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-kaczor
requested review from
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
tzielinski-habana and
xuechendi
as code owners
kamil-kaczor
force-pushed
the
enable_triangular_merged
branch
from
fca8b3f to
9a99d34
Compare
mswiniarsk
approved these changes
Jun 3, 2025
michalkuligowski
requested changes
Jun 27, 2025
| & Kernel(fsdpa) | ||
| & EnvFlag("VLLM_PROMPT_USE_FUSEDSDPA", | ||
| Not(ModelType('mllama')))), | ||
| "triangular_mask": (Not(Hardware("cpu")) |
Contributor
There was a problem hiding this comment.
Please fix conflict
Contributor
Author
There was a problem hiding this comment.
@michalkuligowski converting to draft - there were issues with triangular and I will only merge it once I confirm its stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.