Fix mweb data viz #447
Merged
Fix mweb data viz #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 41.5%, saving 33.22 KB
Some images were already optimised
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #446
One issue was that the YT embed uses an iframe, which the CSS assumed was a chart that would be replaced with a static image. It works to add a
class="fig-mobile"attribute to the iframe so it's retained on mobile.Another issue was that fig5 didn't have a mobile-friendly image. I added that and the markup to show it.
The other issue with the methodology link was that it was markdown inside of an HTML
<aside>element, so it was never converted to markup. We probably could have added themarkdownattribute to fix it but I just converted the link to markup manually.