Document more about eachFile, filesMatching, and filesNotMatching
#1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/202508022/more-examples-for-each-file
branch
6 times, most recently
from
6b4d32e to
d8ddcd8
Compare
Goooler
force-pushed
the
g/202508022/more-examples-for-each-file
branch
from
ee49f5e to
37f53ae
Compare
Goooler
commented
Aug 28, 2025
...kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ServiceFileTransformerTest.kt
Outdated
Show resolved
Hide resolved
…shadow/transformers/ServiceFileTransformerTest.kt
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves documentation for handling duplicate file strategies in the ShadowJar plugin by replacing lengthy inline documentation with a reference to comprehensive web documentation and adding cross-references to related methods.
- Replaces detailed inline steps with a reference to external documentation
- Adds @see annotations for
eachFileandfilesNotMatchingmethods - Enhances test coverage and documentation with comprehensive examples showing different approaches to handling duplicates
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ShadowJar.kt | Simplified KDoc by replacing detailed steps with external documentation reference and added method cross-references |
| ServiceFileTransformerTest.kt | Added new test for eachFile strategy override and improved test method naming consistency |
| docs/configuration/merging/README.md | Expanded documentation with comprehensive examples showing multiple approaches to handling duplicate strategies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1677.