From 4768481e35dad52e4932c0e93a284fb9cbde5f75 Mon Sep 17 00:00:00 2001 From: Pascal Birchler Date: Tue, 15 Apr 2025 16:24:17 +0200 Subject: [PATCH 1/2] Shortcode: enqueue missing script modules --- includes/Assets.php | 22 ++++++++++++++++++++++ includes/Renderer/Stories/Renderer.php | 5 +++++ includes/Renderer/Story/Singleton.php | 5 +++++ 3 files changed, 32 insertions(+) diff --git a/includes/Assets.php b/includes/Assets.php index c2b7b8852e03..89d85efa207e 100644 --- a/includes/Assets.php +++ b/includes/Assets.php @@ -368,6 +368,28 @@ public function enqueue_script( string $script_handle, string $src = '', array $ wp_enqueue_script( $script_handle, $src, $deps, $ver, $in_footer ); } + /** + * Register a new script module. + * + * @SuppressWarnings("PHPMD.BooleanArgumentFlag") + * + * @since 1.40.1 + * + * @param string $script_handle Name of the script module. Should be unique. + * @param string|false $src Full URL of the script, or path of the script relative to the WordPress root directory. + * If source is set to false, script is an alias of other scripts it depends on. + */ + public function enqueue_script_module( string $script_handle, $src ): void { + $asset = $this->get_asset_metadata( $script_handle ); + + wp_enqueue_script_module( + $script_handle, + $src, + $asset['dependencies'], + $asset['version'], + ); + } + /** * Remove admin styles. * diff --git a/includes/Renderer/Stories/Renderer.php b/includes/Renderer/Stories/Renderer.php index b1e55fc3096b..08f55373095c 100644 --- a/includes/Renderer/Stories/Renderer.php +++ b/includes/Renderer/Stories/Renderer.php @@ -355,6 +355,11 @@ public function render_single_story_content(): void { $this->assets->enqueue_style_asset( self::STYLE_HANDLE ); } + wp_enqueue_script_module( + 'web-stories-embed-view', + $this->assets->get_base_url( 'assets/js/web-stories-block-view.js' ) + ); + if ( $this->context->is_amp() ) { ?>
assets->enqueue_script( AMP_Story_Player_Assets::SCRIPT_HANDLE ); $this->assets->enqueue_style_asset( Embed_Base::SCRIPT_HANDLE ); + wp_enqueue_script_module( + 'web-stories-embed-view', + $this->assets->get_base_url( 'assets/js/web-stories-block-view.js' ) + ); + ob_start(); ?>
Date: Tue, 15 Apr 2025 16:45:57 +0200 Subject: [PATCH 2/2] lint fix --- includes/Assets.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/includes/Assets.php b/includes/Assets.php index 89d85efa207e..7cdce8767089 100644 --- a/includes/Assets.php +++ b/includes/Assets.php @@ -375,17 +375,16 @@ public function enqueue_script( string $script_handle, string $src = '', array $ * * @since 1.40.1 * - * @param string $script_handle Name of the script module. Should be unique. - * @param string|false $src Full URL of the script, or path of the script relative to the WordPress root directory. - * If source is set to false, script is an alias of other scripts it depends on. + * @param string $script_handle Name of the script module. Should be unique. + * @param string $src Full URL of the script module. */ - public function enqueue_script_module( string $script_handle, $src ): void { + public function enqueue_script_module( string $script_handle, string $src ): void { $asset = $this->get_asset_metadata( $script_handle ); wp_enqueue_script_module( $script_handle, $src, - $asset['dependencies'], + $asset['dependencies'], // @phpstan-ignore argument.type $asset['version'], ); }