test: add resource type filter to alerts test (#46)

alexander-fenster · web-flow · commit ebf1689b9188 · 2018-05-07T16:01:26.000-07:00
diff --git a/monitoring/snippets/system-test/alerts.test.js b/monitoring/snippets/system-test/alerts.test.js
@@ -44,7 +44,7 @@ test.before(async () => {
         {
           displayName: 'Condition 1',
           conditionAbsent: {
-            filter: `metric.type = "cloudfunctions.googleapis.com/function/execution_count"`,
+            filter: `resource.type = "cloud_function" AND metric.type = "cloudfunctions.googleapis.com/function/execution_count"`,
             aggregations: [
               {
                 alignmentPeriod: {
@@ -75,7 +75,7 @@ test.before(async () => {
         {
           displayName: 'Condition 2',
           conditionAbsent: {
-            filter: `metric.type = "cloudfunctions.googleapis.com/function/execution_count"`,
+            filter: `resource.type = "cloud_function" AND metric.type = "cloudfunctions.googleapis.com/function/execution_count"`,
             aggregations: [
               {
                 alignmentPeriod: {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ test.before(async () => {`
`44`	`44`	`{`
`45`	`45`	`displayName: 'Condition 1',`
`46`	`46`	`conditionAbsent: {`
`47`		- filter: `metric.type = "cloudfunctions.googleapis.com/function/execution_count"`,
	`47`	+ filter: `resource.type = "cloud_function" AND metric.type = "cloudfunctions.googleapis.com/function/execution_count"`,
`48`	`48`	`aggregations: [`
`49`	`49`	`{`
`50`	`50`	`alignmentPeriod: {`
`@@ -75,7 +75,7 @@ test.before(async () => {`
`75`	`75`	`{`
`76`	`76`	`displayName: 'Condition 2',`
`77`	`77`	`conditionAbsent: {`
`78`		- filter: `metric.type = "cloudfunctions.googleapis.com/function/execution_count"`,
	`78`	+ filter: `resource.type = "cloud_function" AND metric.type = "cloudfunctions.googleapis.com/function/execution_count"`,
`79`	`79`	`aggregations: [`
`80`	`80`	`{`
`81`	`81`	`alignmentPeriod: {`