Skip to content

Commit 2f9b1c2

Browse files
docs(samples): refactor webhook samples (#270)
* streamline and clarify webhook samples Change-Id: I80d80b42f60ac6ccc643afb7b2931916d6843813 * remove sessionInfo config Change-Id: I1b14852ad9e238e7cdc04dbb418ed5ed0fca2992 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * hardcode parameter Change-Id: Iea962f2ea2bf73ca86ce3ecd7852a290dd3a2fac * clarify parameter name Change-Id: I5c0a1c654be5133889f4838a118e5bdebe667303 * refactor configure-session-parameter-enable-agent-response sample Change-Id: I62af853767f9097e3448f60060f739ac8bb018b2 * refactor webhook samples Change-Id: I07f2addae8b452d89124d123e3c2be8042ee0292 * remove unnecessary samples Change-Id: Ia936ce14eafb9d44a67a314eb282fb93b5c96319 * change form parameter test Change-Id: Ia7aeb8117f6db4bee2111bdb5bcf6461b2700601 * change sample description Change-Id: I842e1e0bca1eec43d5437cd37575a43b48105bed * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 17093da commit 2f9b1c2

8 files changed

+14
-383
lines changed

dialogflow-cx/test/webhook-configure-session-parameters-enable-agent-response-test.js

Lines changed: 0 additions & 90 deletions
This file was deleted.

dialogflow-cx/test/webhook-configure-session-parameters-test.js

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ describe('configure session parameters', () => {
3939
const request = {
4040
body: {
4141
fulfillmentInfo: {
42-
tag: 'month',
42+
tag: 'configure-session-parameter',
4343
},
4444
},
4545
};
@@ -53,27 +53,6 @@ describe('configure session parameters', () => {
5353
};
5454

5555
webhook.configureSessionParams(JSON.parse(temp), res);
56-
assert.include(response, 'January');
57-
});
58-
59-
it('should test that webhook configures session parameter', async () => {
60-
const request = {
61-
body: {
62-
fulfillmentInfo: {
63-
tag: 'year',
64-
},
65-
},
66-
};
67-
const temp = JSON.stringify(request);
68-
let response = '';
69-
70-
const res = {
71-
send: function (s) {
72-
response = JSON.stringify(s);
73-
},
74-
};
75-
76-
webhook.configureSessionParams(JSON.parse(temp), res);
77-
assert.include(response, '1999');
56+
assert.include(response, 'orderNumber');
7857
});
7958
});

dialogflow-cx/test/webhook-configure-session-parameters-trigger-transition-test.js

Lines changed: 0 additions & 60 deletions
This file was deleted.

dialogflow-cx/test/webhook-validate-form-parameter-test.js

Lines changed: 1 addition & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -35,55 +35,11 @@ const {describe, it} = require('mocha');
3535
const webhook = require('../webhook-validate-form-parameter');
3636

3737
describe('configure session parameters', () => {
38-
it('should test that webhook validates form parameter', async () => {
39-
const number = 4;
40-
const request = {
41-
body: {
42-
fulfillmentInfo: {
43-
tag: 'valid-parameter',
44-
},
45-
pageInfo: {
46-
formInfo: {
47-
parameterInfo: [
48-
{
49-
displayName: 'number',
50-
value: number,
51-
},
52-
],
53-
},
54-
},
55-
},
56-
};
57-
const temp = JSON.stringify(request);
58-
let response = '';
59-
60-
const res = {
61-
send: function (s) {
62-
response = JSON.stringify(s);
63-
},
64-
};
65-
66-
webhook.validateParameter(JSON.parse(temp), res);
67-
assert.include(response, 'VALID');
68-
});
69-
7038
it('should test that webhook invalidates form parameter', async () => {
71-
const number = 150;
7239
const request = {
7340
body: {
7441
fulfillmentInfo: {
75-
tag: 'invalid-parameter',
76-
},
77-
pageInfo: {
78-
formInfo: {
79-
parameterInfo: [
80-
{
81-
displayName: 'number',
82-
required: true,
83-
value: number,
84-
},
85-
],
86-
},
42+
tag: 'invalidate-form-parameter',
8743
},
8844
},
8945
};

dialogflow-cx/webhook-configure-session-parameters-enable-agent-response.js

Lines changed: 0 additions & 65 deletions
This file was deleted.

dialogflow-cx/webhook-configure-session-parameters-trigger-transition.js

Lines changed: 0 additions & 51 deletions
This file was deleted.

0 commit comments

Comments
 (0)